From: Nathan Chancellor <natechancellor@gmail.com>
To: Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org,
Nathan Chancellor <natechancellor@gmail.com>
Subject: [PATCH] pstore: Fix annotation on declaration of pstore_exit_fs
Date: Fri, 19 Oct 2018 11:37:29 -0700 [thread overview]
Message-ID: <20181019183729.27684-1-natechancellor@gmail.com> (raw)
Clang warns (trimmed for brevity):
fs/pstore/inode.c:504:6: error: section does not match previous
declaration [-Werror,-Wsection]
void __exit pstore_exit_fs(void)
^
fs/pstore/internal.h:42:6: note: previous attribute is here
void __init pstore_exit_fs(void);
^
Fixes: a4fb3d2fefd2 ("pstore: Centralize init/exit routines")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
fs/pstore/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pstore/internal.h b/fs/pstore/internal.h
index 98bb4fa6e6a7..7062ea4bc57c 100644
--- a/fs/pstore/internal.h
+++ b/fs/pstore/internal.h
@@ -39,6 +39,6 @@ extern void pstore_record_init(struct pstore_record *record,
/* Called during pstore init/exit. */
int __init pstore_init_fs(void);
-void __init pstore_exit_fs(void);
+void __exit pstore_exit_fs(void);
#endif
--
2.19.1
next reply other threads:[~2018-10-19 18:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 18:37 Nathan Chancellor [this message]
2018-10-19 18:41 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019183729.27684-1-natechancellor@gmail.com \
--to=natechancellor@gmail.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®