* [PATCH] pstore: Fix annotation on declaration of pstore_exit_fs
@ 2018-10-19 18:37 Nathan Chancellor
2018-10-19 18:41 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2018-10-19 18:37 UTC (permalink / raw)
To: Kees Cook, Anton Vorontsov, Colin Cross, Tony Luck
Cc: linux-kernel, Nathan Chancellor
Clang warns (trimmed for brevity):
fs/pstore/inode.c:504:6: error: section does not match previous
declaration [-Werror,-Wsection]
void __exit pstore_exit_fs(void)
^
fs/pstore/internal.h:42:6: note: previous attribute is here
void __init pstore_exit_fs(void);
^
Fixes: a4fb3d2fefd2 ("pstore: Centralize init/exit routines")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
fs/pstore/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pstore/internal.h b/fs/pstore/internal.h
index 98bb4fa6e6a7..7062ea4bc57c 100644
--- a/fs/pstore/internal.h
+++ b/fs/pstore/internal.h
@@ -39,6 +39,6 @@ extern void pstore_record_init(struct pstore_record *record,
/* Called during pstore init/exit. */
int __init pstore_init_fs(void);
-void __init pstore_exit_fs(void);
+void __exit pstore_exit_fs(void);
#endif
--
2.19.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pstore: Fix annotation on declaration of pstore_exit_fs
2018-10-19 18:37 [PATCH] pstore: Fix annotation on declaration of pstore_exit_fs Nathan Chancellor
@ 2018-10-19 18:41 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2018-10-19 18:41 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: Anton Vorontsov, Colin Cross, Tony Luck, LKML
On Fri, Oct 19, 2018 at 11:37 AM, Nathan Chancellor
<natechancellor@gmail.com> wrote:
> Clang warns (trimmed for brevity):
>
> fs/pstore/inode.c:504:6: error: section does not match previous
> declaration [-Werror,-Wsection]
> void __exit pstore_exit_fs(void)
> ^
> fs/pstore/internal.h:42:6: note: previous attribute is here
> void __init pstore_exit_fs(void);
> ^
>
> Fixes: a4fb3d2fefd2 ("pstore: Centralize init/exit routines")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> fs/pstore/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/pstore/internal.h b/fs/pstore/internal.h
> index 98bb4fa6e6a7..7062ea4bc57c 100644
> --- a/fs/pstore/internal.h
> +++ b/fs/pstore/internal.h
> @@ -39,6 +39,6 @@ extern void pstore_record_init(struct pstore_record *record,
>
> /* Called during pstore init/exit. */
> int __init pstore_init_fs(void);
> -void __init pstore_exit_fs(void);
> +void __exit pstore_exit_fs(void);
Whoops! Thanks, I'll fold this fix into the patch.
-Kees
>
> #endif
> --
> 2.19.1
>
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-19 18:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-19 18:37 [PATCH] pstore: Fix annotation on declaration of pstore_exit_fs Nathan Chancellor
2018-10-19 18:41 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®