From: Borislav Petkov <bp@alien8.de>
To: Dave Young <dyoung@redhat.com>
Cc: lijiang <lijiang@redhat.com>, Baoquan He <bhe@redhat.com>,
Petr Tesarik <ptesarik@suse.cz>,
linux-kernel@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, mingo@redhat.com, tglx@linutronix.de,
Kazuhito Hagio <khagio@redhat.com>
Subject: Re: [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo
Date: Wed, 31 Oct 2018 11:10:54 +0100 [thread overview]
Message-ID: <20181031101054.GB15955@zn.tnic> (raw)
In-Reply-To: <20181031024748.GA2058@dhcp-128-65.nay.redhat.com>
On Wed, Oct 31, 2018 at 10:47:48AM +0800, Dave Young wrote:
> It is a mist only a few kdump people know them, documenting them will help
> people to understand and review. It will also be clearer instead of
> digging into code?
Wholeheartedly agreed. Especially if people start using vmcoreinfo for
other stuff, like live debugging:
https://lkml.kernel.org/r/1540593788-28181-1-git-send-email-bhsharma@redhat.com
> The document can briefly explain what is vmcoreinfo, why we need it, and
> some background info. Then list the exported values with some
> classifying by core kernel, arch related, string or number etc. For
> most of them like Baoquan said no need more explanation, but add
> explanations for something if needed like this sme mask.
And add explanations for *all* of them!
If this becomes an API, then it better be documented.
> But I think this can be done separately instead of blocking this patch.
We have three months to the next merge window - I'm sure you guys can do
both. :-)
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-10-31 10:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 9:36 Lianbo Jiang
2018-10-26 9:43 ` Boris Petkov
2018-10-26 12:32 ` lijiang
2018-10-26 16:24 ` Petr Tesarik
2018-10-26 22:25 ` Borislav Petkov
2018-10-27 2:57 ` lijiang
2018-10-27 8:13 ` Baoquan He
2018-10-27 9:10 ` Borislav Petkov
2018-10-27 9:39 ` Baoquan He
2018-10-27 10:12 ` Borislav Petkov
2018-10-27 11:08 ` Baoquan He
2018-10-27 13:17 ` Boris Petkov
2018-10-27 14:41 ` lijiang
2018-10-27 14:51 ` Borislav Petkov
2018-10-29 7:59 ` lijiang
2018-10-29 8:31 ` Baoquan He
2018-10-29 9:29 ` lijiang
2018-10-29 9:57 ` Borislav Petkov
2018-10-29 10:12 ` lijiang
2018-10-29 11:44 ` Baoquan He
2018-10-29 13:41 ` lijiang
2018-10-29 13:49 ` Borislav Petkov
2018-10-30 4:46 ` lijiang
2018-10-30 5:09 ` Dave Young
2018-10-30 9:15 ` Borislav Petkov
2018-10-30 9:23 ` Baoquan He
2018-10-31 2:26 ` lijiang
2018-10-31 2:47 ` Dave Young
2018-10-31 7:43 ` lijiang
2018-10-31 10:10 ` Borislav Petkov [this message]
2018-11-01 15:01 ` Kazuhito Hagio
2018-10-26 16:35 ` Borislav Petkov
2018-10-27 2:19 ` lijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031101054.GB15955@zn.tnic \
--to=bp@alien8.de \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=khagio@redhat.com \
--cc=lijiang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ptesarik@suse.cz \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®