From: David Miller <davem@davemloft.net>
To: ast@fb.com
Cc: songliubraving@fb.com, dsahern@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Kernel-team@fb.com, ast@kernel.org,
daniel@iogearbox.net, peterz@infradead.org, acme@kernel.org
Subject: Re: [RFC perf,bpf 5/5] perf util: generate bpf_prog_info_event for short living bpf programs
Date: Tue, 06 Nov 2018 15:36:47 -0800 (PST) [thread overview]
Message-ID: <20181106.153647.1701013551426767213.davem@davemloft.net> (raw)
In-Reply-To: <27fc8327-3390-ba5a-6063-89c9e7165e7b@fb.com>
From: Alexei Starovoitov <ast@fb.com>
Date: Tue, 6 Nov 2018 23:29:07 +0000
> I think concerns with perf overhead from collecting bpf events
> are unfounded.
> I would prefer for this flag to be on by default.
I will sit in userspace looping over bpf load/unload and see how the
person trying to monitor something else with perf feels about that.
Really, it is inappropriate to turn this on by default, I completely
agree with David Ahern.
It's hard enough, _AS IS_, for me to fight back all of the bloat that
is in perf right now and get it back to being able to handle simple
full workloads without dropping events..
Every new event type like this sets us back.
If people want to monitor new things, or have new functionality, fine.
But not by default, please.
next prev parent reply other threads:[~2018-11-06 23:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 20:52 [RFC perf,bpf 0/5] reveal invisible " Song Liu
2018-11-06 20:52 ` [RFC perf,bpf 1/5] perf, bpf: Introduce PERF_RECORD_BPF_EVENT Song Liu
2018-11-07 8:40 ` Peter Zijlstra
2018-11-07 18:25 ` Song Liu
2018-11-08 15:00 ` Peter Zijlstra
2018-11-08 18:04 ` Song Liu
2018-11-08 18:26 ` David Ahern
2018-11-08 18:49 ` Song Liu
2018-11-09 17:08 ` David Ahern
2018-11-09 18:49 ` Song Liu
2018-11-09 19:14 ` Alexei Starovoitov
2018-11-06 20:52 ` [RFC perf,bpf 2/5] perf: sync tools/include/uapi/linux/perf_event.h Song Liu
2018-11-06 20:52 ` [RFC perf,bpf 3/5] perf util: basic handling of PERF_RECORD_BPF_EVENT Song Liu
2018-11-06 20:52 ` [RFC perf,bpf 4/5] perf util: introduce bpf_prog_info_event Song Liu
2018-11-06 21:11 ` Alexei Starovoitov
2018-11-06 20:52 ` [RFC perf,bpf 5/5] perf util: generate bpf_prog_info_event for short living bpf programs Song Liu
2018-11-06 21:54 ` David Ahern
2018-11-06 23:17 ` Song Liu
2018-11-06 23:29 ` Alexei Starovoitov
2018-11-06 23:36 ` David Miller [this message]
2018-11-07 0:13 ` Alexei Starovoitov
2018-11-07 0:23 ` David Ahern
2018-11-07 0:26 ` Alexei Starovoitov
2018-11-07 0:44 ` David Ahern
2018-11-07 1:09 ` Alexei Starovoitov
2018-11-07 18:12 ` David Ahern
2018-11-07 18:28 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106.153647.1701013551426767213.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Kernel-team@fb.com \
--cc=acme@kernel.org \
--cc=ast@fb.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®