* [PATCH] ASoC: pcm186x: Fix device reset-registers trigger value
@ 2018-11-15 17:01 Andreas Dannenberg
2018-11-15 17:08 ` Andrew F. Davis
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Dannenberg @ 2018-11-15 17:01 UTC (permalink / raw)
To: Mark Brown
Cc: Andreas Dannenberg, alsa-devel, linux-kernel,
Stephane Le Provost, Andrew F Davis
According to the current device datasheet (TI Lit # SLAS831D, revised
March 2018) the value written to the device's PAGE register to trigger
a complete register reset should be 0xfe, not 0xff. So go ahead and
update to the correct value.
Reported-by: Stephane Le Provost <stephane.leprovost@mediatek.com>
Tested-by: Stephane Le Provost <stephane.leprovost@mediatek.com>
Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
---
sound/soc/codecs/pcm186x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/pcm186x.h b/sound/soc/codecs/pcm186x.h
index 2c6ba55bf394..bb3f0c42a1cd 100644
--- a/sound/soc/codecs/pcm186x.h
+++ b/sound/soc/codecs/pcm186x.h
@@ -139,7 +139,7 @@ enum pcm186x_type {
#define PCM186X_MAX_REGISTER PCM186X_CURR_TRIM_CTRL
/* PCM186X_PAGE */
-#define PCM186X_RESET 0xff
+#define PCM186X_RESET 0xfe
/* PCM186X_ADCX_INPUT_SEL_X */
#define PCM186X_ADC_INPUT_SEL_POL BIT(7)
--
2.15.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: pcm186x: Fix device reset-registers trigger value
2018-11-15 17:01 [PATCH] ASoC: pcm186x: Fix device reset-registers trigger value Andreas Dannenberg
@ 2018-11-15 17:08 ` Andrew F. Davis
0 siblings, 0 replies; 2+ messages in thread
From: Andrew F. Davis @ 2018-11-15 17:08 UTC (permalink / raw)
To: Andreas Dannenberg, Mark Brown
Cc: alsa-devel, linux-kernel, Stephane Le Provost
On 11/15/18 11:01 AM, Andreas Dannenberg wrote:
> According to the current device datasheet (TI Lit # SLAS831D, revised
> March 2018) the value written to the device's PAGE register to trigger
> a complete register reset should be 0xfe, not 0xff. So go ahead and
> update to the correct value.
>
> Reported-by: Stephane Le Provost <stephane.leprovost@mediatek.com>
> Tested-by: Stephane Le Provost <stephane.leprovost@mediatek.com>
> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> ---
Does 0xff not reset the device? If so then this is not just a typo but a
bug and this patch should have a fixes tag. Either way:
Acked-by: Andrew F. Davis <afd@ti.com>
> sound/soc/codecs/pcm186x.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/pcm186x.h b/sound/soc/codecs/pcm186x.h
> index 2c6ba55bf394..bb3f0c42a1cd 100644
> --- a/sound/soc/codecs/pcm186x.h
> +++ b/sound/soc/codecs/pcm186x.h
> @@ -139,7 +139,7 @@ enum pcm186x_type {
> #define PCM186X_MAX_REGISTER PCM186X_CURR_TRIM_CTRL
>
> /* PCM186X_PAGE */
> -#define PCM186X_RESET 0xff
> +#define PCM186X_RESET 0xfe
>
> /* PCM186X_ADCX_INPUT_SEL_X */
> #define PCM186X_ADC_INPUT_SEL_POL BIT(7)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-15 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-15 17:01 [PATCH] ASoC: pcm186x: Fix device reset-registers trigger value Andreas Dannenberg
2018-11-15 17:08 ` Andrew F. Davis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®