mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <linux-kernel@vger.kernel.org>,
	<patches@opensource.cirrus.com>
Subject: [PATCH 0/2] Allow regulator nodes to hold their own init data
Date: Thu, 29 Nov 2018 10:28:19 +0000	[thread overview]
Message-ID: <20181129102821.18396-1-ckeepax@opensource.cirrus.com> (raw)

Unfortunately due to a rather large testing oversight on my
part the recently merged Lochnagar regulator binding does not
actually work. The binding looks like this:

lochnagar {
        compatible = "cirrus,lochnagar1";

        ...

        lochnagar-micvdd: MICVDD {
                compatible = "cirrus,lochnagar2-micvdd";

                SYSVDD-supply = <&wallvdd>;

                regulator-min-microvolt = <3300000>;
                regulator-max-microvolt = <3300000>;
        };
        lochnagar-vddcore: VDDCORE {
                compatible = "cirrus,lochnagar2-vddcore";

                SYSVDD-supply = <&wallvdd>;

                regulator-min-microvolt = <1200000>;
                regulator-max-microvolt = <1200000>;
        };
};

The trouble is that each regulator node individually binds
in a driver and contains the init data. The regulator core
appears to require the init data to be a sub-node of the node
that bound in the regulator driver. As the above binding seems
reasonable I opted to try and update the core to support the
current binding, although as the rest of the Lochnagar driver
isn't merged yet we could still update the binding if that comes
out of the review as a preferred option. Apologies for missing
such a glaring issue in my testing.

Thanks,
Charles

Charles Keepax (2):
  regulator: Factor out location of init data OF node
  regulator: Allow regulator nodes to contain their own init data

 drivers/regulator/of_regulator.c | 72 ++++++++++++++++++++++++----------------
 1 file changed, 43 insertions(+), 29 deletions(-)

-- 
2.11.0


             reply	other threads:[~2018-11-29 10:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 10:28 Charles Keepax [this message]
2018-11-29 10:28 ` [PATCH 1/2] regulator: Factor out location of init data OF node Charles Keepax
2018-11-29 10:28 ` [PATCH 2/2] regulator: Allow regulator nodes to contain their own init data Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129102821.18396-1-ckeepax@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®