mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yu Chen <chenyu56@huawei.com>
To: <linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <suzhuangluan@hisilicon.com>, <kongfei@hisilicon.com>,
	Yu Chen <chenyu56@huawei.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	"John Stultz" <john.stultz@linaro.org>
Subject: [PATCH v1 07/12] usb: roles: Find the usb role switch by also matching against the device node
Date: Mon, 3 Dec 2018 11:45:10 +0800	[thread overview]
Message-ID: <20181203034515.91412-8-chenyu56@huawei.com> (raw)
In-Reply-To: <20181203034515.91412-1-chenyu56@huawei.com>

This patch adds code for supporting find usb role switch by matching against
the device node described using of_graph.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: John Stultz <john.stultz@linaro.org>
Signed-off-by: Yu Chen <chenyu56@huawei.com>
---
 drivers/usb/common/roles.c | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/drivers/usb/common/roles.c b/drivers/usb/common/roles.c
index 99116af07f1d..0f48090c5c30 100644
--- a/drivers/usb/common/roles.c
+++ b/drivers/usb/common/roles.c
@@ -12,6 +12,8 @@
 #include <linux/module.h>
 #include <linux/mutex.h>
 #include <linux/slab.h>
+#include <linux/of.h>
+#include <linux/of_graph.h>
 
 static struct class *role_class;
 
@@ -100,6 +102,38 @@ static void *usb_role_switch_match(struct device_connection *con, int ep,
 	return dev ? to_role_switch(dev) : ERR_PTR(-EPROBE_DEFER);
 }
 
+static int __switch_match_by_of_node(struct device *dev, const void *name)
+{
+	if (!dev->parent || !dev->parent->of_node)
+		return 0;
+
+	return of_node_name_eq(dev->parent->of_node, (const char *)name);
+}
+
+static void *of_graph_find_match_by_type(struct device *dev, const char *ep_type)
+{
+	struct device_node *ep;
+	struct device_node *remote_parent;
+	struct device *role_switch;
+
+	for_each_endpoint_of_node(dev_of_node(dev), ep) {
+		if (!ep->type || strcmp(ep->type, ep_type))
+			continue;
+
+		remote_parent = of_graph_get_remote_port_parent(ep);
+		if (!remote_parent || !remote_parent->name)
+			continue;
+
+		role_switch = class_find_device(role_class, NULL,
+				remote_parent->name, __switch_match_by_of_node);
+
+		return role_switch ? to_role_switch(role_switch) :
+			ERR_PTR(-EPROBE_DEFER);
+	}
+
+	return NULL;
+}
+
 /**
  * usb_role_switch_get - Find USB role switch linked with the caller
  * @dev: The caller device
@@ -114,6 +148,12 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev)
 	sw = device_connection_find_match(dev, "usb-role-switch", NULL,
 					  usb_role_switch_match);
 
+	if (!IS_ERR_OR_NULL(sw)) {
+		WARN_ON(!try_module_get(sw->dev.parent->driver->owner));
+		return sw;
+	}
+
+	sw = of_graph_find_match_by_type(dev, "usb-role-switch");
 	if (!IS_ERR_OR_NULL(sw))
 		WARN_ON(!try_module_get(sw->dev.parent->driver->owner));
 
-- 
2.15.0-rc2


  parent reply	other threads:[~2018-12-03  3:46 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03  3:45 [PATCH v1 00/12] Add support for usb on Hikey960 Yu Chen
2018-12-03  3:45 ` [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs Yu Chen
2018-12-03  8:35   ` Sergei Shtylyov
2018-12-03  8:51     ` Chen Yu
2018-12-03  8:59       ` Sergei Shtylyov
2018-12-03  9:28         ` Chen Yu
2018-12-19 14:09           ` Rob Herring
2018-12-20  1:33             ` Chen Yu
2018-12-20  6:46             ` Felipe Balbi
2018-12-20 13:48               ` Rob Herring
2018-12-03  3:45 ` [PATCH v1 02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen
2018-12-19 14:14   ` Rob Herring
2018-12-20  1:52     ` Chen Yu
2018-12-03  3:45 ` [PATCH v1 03/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen
2018-12-19 14:21   ` Rob Herring
2018-12-20  2:02     ` Chen Yu
2018-12-03  3:45 ` [PATCH v1 04/12] usb: dwc3: dwc3-hisi: Add code for dwc3 of Hisilicon Soc Platform Yu Chen
2018-12-03  8:12   ` Andy Shevchenko
2018-12-03  8:30     ` Chen Yu
2018-12-03  3:45 ` [PATCH v1 05/12] usb: dwc3: Add two quirks for Hisilicon Kirin " Yu Chen
2018-12-03  8:02   ` Andy Shevchenko
2018-12-03  8:23     ` Chen Yu
2018-12-03  3:45 ` [PATCH v1 06/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2018-12-03  8:14   ` Andy Shevchenko
2018-12-03  3:45 ` Yu Chen [this message]
2018-12-03  8:17   ` [PATCH v1 07/12] usb: roles: Find the usb role switch by also matching against the device node Andy Shevchenko
2018-12-03 12:25     ` Heikki Krogerus
2019-01-21  8:36       ` Chen Yu
2019-01-21 13:51         ` Heikki Krogerus
2019-01-25 12:35           ` Heikki Krogerus
2018-12-03  3:45 ` [PATCH v1 08/12] usb: roles: Add usb role switch notifier Yu Chen
2018-12-03 12:38   ` Heikki Krogerus
2018-12-04  1:07     ` Chen Yu
2018-12-03  3:45 ` [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code Yu Chen
2018-12-03  9:15   ` Andy Shevchenko
2018-12-03  9:30     ` Chen Yu
2018-12-03 12:43   ` Heikki Krogerus
2018-12-04 10:54   ` Heikki Krogerus
2018-12-05  0:56     ` Chen Yu
2018-12-03  3:45 ` [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960 Yu Chen
2018-12-03  9:23   ` Andy Shevchenko
2018-12-04  1:40     ` Chen Yu
2018-12-04 17:47       ` Andy Shevchenko
2018-12-05  1:57         ` Chen Yu
2018-12-05  8:44           ` Andy Shevchenko
2018-12-03  3:45 ` [PATCH v1 11/12] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen
2018-12-03  9:25   ` Andy Shevchenko
2018-12-04  1:22     ` Chen Yu
2018-12-03  9:53   ` Krzysztof Opasiak
2018-12-03  3:45 ` [PATCH v1 12/12] dts: hi3660: Add support for usb on Hikey960 Yu Chen
2018-12-04 12:45   ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181203034515.91412-8-chenyu56@huawei.com \
    --to=chenyu56@huawei.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=john.stultz@linaro.org \
    --cc=kongfei@hisilicon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=suzhuangluan@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®