mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Sean Paul <sean@poorly.run>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-sunxi@googlegroups.com, Daniel Vetter <daniel@ffwll.ch>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Subject: [PATCH v3 05/21] drm/sun4i: frontend: Determine input format based on colorspace
Date: Tue,  4 Dec 2018 15:22:02 +0100	[thread overview]
Message-ID: <20181204142218.16284-6-paul.kocialkowski@bootlin.com> (raw)
In-Reply-To: <20181204142218.16284-1-paul.kocialkowski@bootlin.com>

Since all the RGB input formats have the same value for the DATA_FMT
field of the INPUT_FMT register, we can group them when the format is
known to be RGB. Here, we assume that a non-YUV format is RGB, because
the hardware does not support any other colorspace than RGB and YUV.

Pass the full DRM format info structure to check whether the format uses
a YUV colorspace.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
 drivers/gpu/drm/sun4i/sun4i_frontend.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/sun4i/sun4i_frontend.c b/drivers/gpu/drm/sun4i/sun4i_frontend.c
index c436fa97928f..d0eca4b8784d 100644
--- a/drivers/gpu/drm/sun4i/sun4i_frontend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_frontend.c
@@ -104,16 +104,16 @@ void sun4i_frontend_update_buffer(struct sun4i_frontend *frontend,
 }
 EXPORT_SYMBOL(sun4i_frontend_update_buffer);
 
-static int sun4i_frontend_drm_format_to_input_fmt(uint32_t fmt, u32 *val)
+static int
+sun4i_frontend_drm_format_to_input_fmt(const struct drm_format_info *format,
+				       u32 *val)
 {
-	switch (fmt) {
-	case DRM_FORMAT_XRGB8888:
+	if (!format->is_yuv)
 		*val = SUN4I_FRONTEND_INPUT_FMT_DATA_FMT_RGB;
-		return 0;
-
-	default:
+	else
 		return -EINVAL;
-	}
+
+	return 0;
 }
 
 static int
@@ -190,8 +190,7 @@ int sun4i_frontend_update_formats(struct sun4i_frontend *frontend,
 	u32 in_fmt_val, in_mod_val, in_ps_val;
 	int ret;
 
-	ret = sun4i_frontend_drm_format_to_input_fmt(format->format,
-						     &in_fmt_val);
+	ret = sun4i_frontend_drm_format_to_input_fmt(format, &in_fmt_val);
 	if (ret) {
 		DRM_DEBUG_DRIVER("Invalid input format\n");
 		return ret;
-- 
2.19.2


  parent reply	other threads:[~2018-12-04 14:24 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 14:21 [PATCH v3 00/21] drm/sun4i: Support for linear and tiled YUV formats with the frontend Paul Kocialkowski
2018-12-04 14:21 ` [PATCH v3 01/21] drm/fourcc: Add format info helpers for checking YUV planes disposition Paul Kocialkowski
2018-12-04 14:21 ` [PATCH v3 02/21] drm/fourcc: Add format info helpers for checking YUV sub-sampling Paul Kocialkowski
2018-12-04 14:22 ` [PATCH v3 03/21] drm/sun4i: backend: Use explicit fourcc helpers for packed YUV422 check Paul Kocialkowski
2018-12-04 14:22 ` [PATCH v3 04/21] drm/sun4i: frontend: Pass DRM format info to input mode helper Paul Kocialkowski
2018-12-04 15:21   ` Maxime Ripard
2018-12-04 14:22 ` Paul Kocialkowski [this message]
2018-12-04 14:22 ` [PATCH v3 06/21] drm/sun4i: frontend: Configure and enable YUV to RGB CSC when needed Paul Kocialkowski
2018-12-04 15:29   ` Maxime Ripard
2018-12-04 14:22 ` [PATCH v3 07/21] drm/sun4i: frontend: Add support for packed YUV422 input formats Paul Kocialkowski
2018-12-04 15:29   ` Maxime Ripard
2018-12-04 14:22 ` [PATCH v3 08/21] drm/sun4i: frontend: Add support for semi-planar YUV " Paul Kocialkowski
2018-12-04 15:30   ` Maxime Ripard
2018-12-04 14:22 ` [PATCH v3 09/21] drm/sun4i: frontend: Add support for planar " Paul Kocialkowski
2018-12-04 15:30   ` Maxime Ripard
2018-12-04 14:22 ` [PATCH v3 10/21] drm/fourcc: Add definitions for Allwinner vendor and VPU tiled format Paul Kocialkowski
2018-12-04 14:22 ` [PATCH v3 11/21] drm/sun4i: frontend: Add support for tiled YUV input mode configuration Paul Kocialkowski
2018-12-04 15:31   ` Maxime Ripard
2018-12-04 14:22 ` [PATCH v3 12/21] drm/sun4i: Add buffer stride and offset configuration for tiling mode Paul Kocialkowski
2018-12-04 15:34   ` Maxime Ripard
2018-12-04 14:22 ` [PATCH v3 13/21] drm/sun4i: frontend: Add and use helper for checking tiling support Paul Kocialkowski
2018-12-04 15:34   ` Maxime Ripard
2018-12-04 14:22 ` [PATCH v3 14/21] drm/sun4i: layer: Add tiled modifier support and helper Paul Kocialkowski
2018-12-04 15:34   ` Maxime Ripard
2018-12-04 14:22 ` [PATCH v3 15/21] drm/sun4i: drv: Allow framebuffer modifiers in mode config Paul Kocialkowski
2018-12-04 15:34   ` Maxime Ripard
2018-12-04 14:22 ` [PATCH v3 16/21] drm/sun4i: Move access control before setting the register as documented Paul Kocialkowski
2018-12-04 14:22 ` [PATCH v3 17/21] drm/sun4i: frontend: Add a quirk structure Paul Kocialkowski
2018-12-04 14:22 ` [PATCH v3 18/21] drm/sun4i: Set the coef_rdy bit right after the coef have been set Paul Kocialkowski
2018-12-04 14:22 ` [PATCH v3 19/21] drm/sun4i: Make COEF_RDY conditional Paul Kocialkowski
2018-12-04 14:22 ` [PATCH v3 20/21] drm/sun4i: frontend: Move the FIR filter phases to our quirks Paul Kocialkowski
2018-12-04 14:22 ` [PATCH v3 21/21] drm/sun4i: frontend: Add A20-specific device-tree compatible and quirks Paul Kocialkowski
2018-12-04 15:35   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181204142218.16284-6-paul.kocialkowski@bootlin.com \
    --to=paul.kocialkowski@bootlin.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=sean@poorly.run \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®