* [PATCH] firmware: qcom: scm: fix compilation error when disabled
@ 2018-11-22 2:32 Jonathan Marek
2018-12-05 17:37 ` Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Marek @ 2018-11-22 2:32 UTC (permalink / raw)
To: bjorn.andersson
Cc: Andy Gross, Niklas Cassel, Kalle Valo, Brian Norris,
Jordan Crouse, Govind Singh, open list
This fixes the case when CONFIG_QCOM_SCM is not enabled, and linux/errno.h
has not been included previously.
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
drm/msm includes qcom_scm.h, but can be used with non-qcom hw (IMX5)
include/linux/qcom_scm.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h
index 06996ad4f2bc..1637385bcc17 100644
--- a/include/linux/qcom_scm.h
+++ b/include/linux/qcom_scm.h
@@ -67,6 +67,9 @@ extern int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare);
extern int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val);
extern int qcom_scm_io_writel(phys_addr_t addr, unsigned int val);
#else
+
+#include <linux/errno.h>
+
static inline
int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus)
{
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: qcom: scm: fix compilation error when disabled
2018-11-22 2:32 [PATCH] firmware: qcom: scm: fix compilation error when disabled Jonathan Marek
@ 2018-12-05 17:37 ` Bjorn Andersson
2018-12-05 22:44 ` Andy Gross
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2018-12-05 17:37 UTC (permalink / raw)
To: Jonathan Marek
Cc: Andy Gross, Niklas Cassel, Kalle Valo, Brian Norris,
Jordan Crouse, Govind Singh, open list, linux-arm-msm
+ linux-arm-msm
On Wed 21 Nov 18:32 PST 2018, Jonathan Marek wrote:
> This fixes the case when CONFIG_QCOM_SCM is not enabled, and linux/errno.h
> has not been included previously.
>
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drm/msm includes qcom_scm.h, but can be used with non-qcom hw (IMX5)
>
> include/linux/qcom_scm.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h
> index 06996ad4f2bc..1637385bcc17 100644
> --- a/include/linux/qcom_scm.h
> +++ b/include/linux/qcom_scm.h
> @@ -67,6 +67,9 @@ extern int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare);
> extern int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val);
> extern int qcom_scm_io_writel(phys_addr_t addr, unsigned int val);
> #else
> +
> +#include <linux/errno.h>
> +
> static inline
> int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus)
> {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: qcom: scm: fix compilation error when disabled
2018-12-05 17:37 ` Bjorn Andersson
@ 2018-12-05 22:44 ` Andy Gross
0 siblings, 0 replies; 3+ messages in thread
From: Andy Gross @ 2018-12-05 22:44 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Jonathan Marek, Niklas Cassel, Kalle Valo, Brian Norris,
Jordan Crouse, Govind Singh, open list, linux-arm-msm
On Wed, Dec 05, 2018 at 09:37:21AM -0800, Bjorn Andersson wrote:
> + linux-arm-msm
>
> On Wed 21 Nov 18:32 PST 2018, Jonathan Marek wrote:
>
> > This fixes the case when CONFIG_QCOM_SCM is not enabled, and linux/errno.h
> > has not been included previously.
> >
> > Signed-off-by: Jonathan Marek <jonathan@marek.ca>
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Got it queued.
Andy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-05 22:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-22 2:32 [PATCH] firmware: qcom: scm: fix compilation error when disabled Jonathan Marek
2018-12-05 17:37 ` Bjorn Andersson
2018-12-05 22:44 ` Andy Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®