From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, Oscar Salvador <osalvador@suse.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Stefan Agner <stefan@agner.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: mm: remove unused variable
Date: Tue, 11 Dec 2018 09:02:19 +1100 [thread overview]
Message-ID: <20181211090219.52ef9144@canb.auug.org.au> (raw)
In-Reply-To: <20181210205309.2794444-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]
Hi Arnd,
On Mon, 10 Dec 2018 21:53:02 +0100 Arnd Bergmann <arnd@arndb.de> wrote:
>
> A recent change dropped the only user of the variable, which should
> now be removed as well to avoid this warning:
>
> arch/x86/mm/init_32.c: In function 'arch_remove_memory':
> arch/x86/mm/init_32.c:867:15: error: unused variable 'zone' [-Werror=unused-variable]
>
> Fixes: dd99d07f818b ("mm, memory_hotplug: move zone/pages handling to offline stage")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/x86/mm/init_32.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
> index 0b8c7b0033d2..c75c26497c4f 100644
> --- a/arch/x86/mm/init_32.c
> +++ b/arch/x86/mm/init_32.c
> @@ -864,7 +864,6 @@ int arch_remove_memory(int nid, u64 start, u64 size, struct vmem_altmap *altmap)
> {
> unsigned long start_pfn = start >> PAGE_SHIFT;
> unsigned long nr_pages = size >> PAGE_SHIFT;
> - struct zone *zone;
>
> return remove_sections(nid, start_pfn, nr_pages, altmap);
> }
I have added that to the akpm-current tree for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-12-10 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 20:53 Arnd Bergmann
2018-12-10 21:28 ` Thomas Gleixner
2018-12-10 22:02 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211090219.52ef9144@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=osalvador@suse.com \
--cc=peterz@infradead.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®