* [PATCH] x86: mm: remove unused variable
@ 2018-12-10 20:53 Arnd Bergmann
2018-12-10 21:28 ` Thomas Gleixner
2018-12-10 22:02 ` Stephen Rothwell
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2018-12-10 20:53 UTC (permalink / raw)
To: Dave Hansen, Andy Lutomirski, Peter Zijlstra, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, x86
Cc: Oscar Salvador, Arnd Bergmann, H. Peter Anvin, Andrew Morton,
Stephen Rothwell, Mike Rapoport, Stefan Agner, linux-kernel
A recent change dropped the only user of the variable, which should
now be removed as well to avoid this warning:
arch/x86/mm/init_32.c: In function 'arch_remove_memory':
arch/x86/mm/init_32.c:867:15: error: unused variable 'zone' [-Werror=unused-variable]
Fixes: dd99d07f818b ("mm, memory_hotplug: move zone/pages handling to offline stage")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/x86/mm/init_32.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
index 0b8c7b0033d2..c75c26497c4f 100644
--- a/arch/x86/mm/init_32.c
+++ b/arch/x86/mm/init_32.c
@@ -864,7 +864,6 @@ int arch_remove_memory(int nid, u64 start, u64 size, struct vmem_altmap *altmap)
{
unsigned long start_pfn = start >> PAGE_SHIFT;
unsigned long nr_pages = size >> PAGE_SHIFT;
- struct zone *zone;
return remove_sections(nid, start_pfn, nr_pages, altmap);
}
--
2.20.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86: mm: remove unused variable
2018-12-10 20:53 [PATCH] x86: mm: remove unused variable Arnd Bergmann
@ 2018-12-10 21:28 ` Thomas Gleixner
2018-12-10 22:02 ` Stephen Rothwell
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Gleixner @ 2018-12-10 21:28 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Dave Hansen, Andy Lutomirski, Peter Zijlstra, Ingo Molnar,
Borislav Petkov, x86, Oscar Salvador, H. Peter Anvin,
Andrew Morton, Stephen Rothwell, Mike Rapoport, Stefan Agner,
linux-kernel
On Mon, 10 Dec 2018, Arnd Bergmann wrote:
> A recent change dropped the only user of the variable, which should
> now be removed as well to avoid this warning:
>
> arch/x86/mm/init_32.c: In function 'arch_remove_memory':
> arch/x86/mm/init_32.c:867:15: error: unused variable 'zone' [-Werror=unused-variable]
>
> Fixes: dd99d07f818b ("mm, memory_hotplug: move zone/pages handling to offline stage")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86: mm: remove unused variable
2018-12-10 20:53 [PATCH] x86: mm: remove unused variable Arnd Bergmann
2018-12-10 21:28 ` Thomas Gleixner
@ 2018-12-10 22:02 ` Stephen Rothwell
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2018-12-10 22:02 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Dave Hansen, Andy Lutomirski, Peter Zijlstra, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, x86, Oscar Salvador,
H. Peter Anvin, Andrew Morton, Mike Rapoport, Stefan Agner,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]
Hi Arnd,
On Mon, 10 Dec 2018 21:53:02 +0100 Arnd Bergmann <arnd@arndb.de> wrote:
>
> A recent change dropped the only user of the variable, which should
> now be removed as well to avoid this warning:
>
> arch/x86/mm/init_32.c: In function 'arch_remove_memory':
> arch/x86/mm/init_32.c:867:15: error: unused variable 'zone' [-Werror=unused-variable]
>
> Fixes: dd99d07f818b ("mm, memory_hotplug: move zone/pages handling to offline stage")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/x86/mm/init_32.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
> index 0b8c7b0033d2..c75c26497c4f 100644
> --- a/arch/x86/mm/init_32.c
> +++ b/arch/x86/mm/init_32.c
> @@ -864,7 +864,6 @@ int arch_remove_memory(int nid, u64 start, u64 size, struct vmem_altmap *altmap)
> {
> unsigned long start_pfn = start >> PAGE_SHIFT;
> unsigned long nr_pages = size >> PAGE_SHIFT;
> - struct zone *zone;
>
> return remove_sections(nid, start_pfn, nr_pages, altmap);
> }
I have added that to the akpm-current tree for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-10 22:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-10 20:53 [PATCH] x86: mm: remove unused variable Arnd Bergmann
2018-12-10 21:28 ` Thomas Gleixner
2018-12-10 22:02 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®