* [PATCH net-next] bnxt: remove printing of hwrm message [not found] <CACKFLi=bOMKnmucRTNUyG=xWYWADJ61COFy2U-7rph0WRWR4Yg@mail.gmail.com> @ 2018-12-12 16:58 ` Jonathan Toppins 2018-12-12 17:26 ` Michael Chan 2018-12-13 0:32 ` David Miller 0 siblings, 2 replies; 3+ messages in thread From: Jonathan Toppins @ 2018-12-12 16:58 UTC (permalink / raw) To: netdev; +Cc: michael.chan, David S. Miller, linux-kernel bnxt_en 0000:19:00.0 (unregistered net_device) (uninitialized): hwrm req_type 0x190 seq id 0x6 error 0xffff The message above is commonly seen when a newer driver is used on hardware with older firmware. The issue is this message means nothing to anyone except Broadcom. Remove the message to not confuse users as this message is really not very informative. Signed-off-by: Jonathan Toppins <jtoppins@redhat.com> --- Notes: v2: include changes recommended by Michael Chan drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 5d21c14853ac..f4f29939ba72 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -6190,7 +6190,8 @@ int bnxt_hwrm_func_resc_qcaps(struct bnxt *bp, bool all) req.fid = cpu_to_le16(0xffff); mutex_lock(&bp->hwrm_cmd_lock); - rc = _hwrm_send_message(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT); + rc = _hwrm_send_message_silent(bp, &req, sizeof(req), + HWRM_CMD_TIMEOUT); if (rc) { rc = -EIO; goto hwrm_func_resc_qcaps_exit; -- 2.16.4 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] bnxt: remove printing of hwrm message 2018-12-12 16:58 ` [PATCH net-next] bnxt: remove printing of hwrm message Jonathan Toppins @ 2018-12-12 17:26 ` Michael Chan 2018-12-13 0:32 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: Michael Chan @ 2018-12-12 17:26 UTC (permalink / raw) To: Jonathan Toppins; +Cc: Netdev, David Miller, open list On Wed, Dec 12, 2018 at 8:59 AM Jonathan Toppins <jtoppins@redhat.com> wrote: > > bnxt_en 0000:19:00.0 (unregistered net_device) (uninitialized): hwrm > req_type 0x190 seq id 0x6 error 0xffff > > The message above is commonly seen when a newer driver is used on > hardware with older firmware. The issue is this message means nothing to > anyone except Broadcom. Remove the message to not confuse users as this > message is really not very informative. > > Signed-off-by: Jonathan Toppins <jtoppins@redhat.com> > --- > > Notes: > v2: > include changes recommended by Michael Chan > Acked-by: Michael Chan <michael.chan@broadcom.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] bnxt: remove printing of hwrm message 2018-12-12 16:58 ` [PATCH net-next] bnxt: remove printing of hwrm message Jonathan Toppins 2018-12-12 17:26 ` Michael Chan @ 2018-12-13 0:32 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: David Miller @ 2018-12-13 0:32 UTC (permalink / raw) To: jtoppins; +Cc: netdev, michael.chan, linux-kernel From: Jonathan Toppins <jtoppins@redhat.com> Date: Wed, 12 Dec 2018 11:58:51 -0500 > bnxt_en 0000:19:00.0 (unregistered net_device) (uninitialized): hwrm > req_type 0x190 seq id 0x6 error 0xffff > > The message above is commonly seen when a newer driver is used on > hardware with older firmware. The issue is this message means nothing to > anyone except Broadcom. Remove the message to not confuse users as this > message is really not very informative. > > Signed-off-by: Jonathan Toppins <jtoppins@redhat.com> > --- > > Notes: > v2: > include changes recommended by Michael Chan Applied, thank you. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-13 0:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CACKFLi=bOMKnmucRTNUyG=xWYWADJ61COFy2U-7rph0WRWR4Yg@mail.gmail.com>
2018-12-12 16:58 ` [PATCH net-next] bnxt: remove printing of hwrm message Jonathan Toppins
2018-12-12 17:26 ` Michael Chan
2018-12-13 0:32 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®