From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: mcuos.com@gmail.com, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] w90p910_ether: remove incorrect __init annotation
Date: Fri, 14 Dec 2018 13:23:00 -0800 (PST) [thread overview]
Message-ID: <20181214.132300.832860946069084294.davem@davemloft.net> (raw)
In-Reply-To: <20181210204514.2362328-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 10 Dec 2018 21:45:07 +0100
> The get_mac_address() function is normally inline, but when it is
> not, we get a warning that this configuration is broken:
>
> WARNING: vmlinux.o(.text+0x4aff00): Section mismatch in reference from the function w90p910_ether_setup() to the function .init.text:get_mac_address()
> The function w90p910_ether_setup() references
> the function __init get_mac_address().
> This is often because w90p910_ether_setup lacks a __init
>
> Remove the __init to make it always do the right thing.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Actually I think we can validly mark w90p910_ether_setup() and
w90p910_probe() with appropriate init tagging. None of these
functions are invoked outside of the probing paths.
next prev parent reply other threads:[~2018-12-14 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 20:45 Arnd Bergmann
2018-12-14 21:23 ` David Miller [this message]
2018-12-14 22:22 ` Arnd Bergmann
2018-12-14 22:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214.132300.832860946069084294.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcuos.com@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®