mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
	linux-kernel@vger.kernel.org, Dong Aisheng <aisheng.dong@nxp.com>,
	Vladimir Zapolskiy <vz@mleia.com>
Subject: Re: [PATCH v2 08/19] mailbox: imx: Use device-managed registration API
Date: Mon, 17 Dec 2018 16:31:08 +0100	[thread overview]
Message-ID: <20181217153108.ycu7xg25edzccv7g@pengutronix.de> (raw)
In-Reply-To: <20181217150217.32435-9-thierry.reding@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]

On Mon, Dec 17, 2018 at 04:02:06PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Get rid of some boilerplate driver removal code by using the newly added
> device-managed registration API.
> 
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> Cc: Dong Aisheng <aisheng.dong@nxp.com>
> Cc: Vladimir Zapolskiy <vz@mleia.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>

> ---
>  drivers/mailbox/imx-mailbox.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index 363d35d5e49d..774362a05159 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -324,14 +324,13 @@ static int imx_mu_probe(struct platform_device *pdev)
>  
>  	imx_mu_init_generic(priv);
>  
> -	return mbox_controller_register(&priv->mbox);
> +	return devm_mbox_controller_register(dev, &priv->mbox);
>  }
>  
>  static int imx_mu_remove(struct platform_device *pdev)
>  {
>  	struct imx_mu_priv *priv = platform_get_drvdata(pdev);
>  
> -	mbox_controller_unregister(&priv->mbox);
>  	clk_disable_unprepare(priv->clk);
>  
>  	return 0;
> -- 
> 2.19.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-12-17 15:31 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 15:01 [PATCH v2 00/19] mailbox: Device-managed registration Thierry Reding
2018-12-17 15:01 ` [PATCH v2 01/19] mailbox: Add device-managed registration functions Thierry Reding
2018-12-17 18:15   ` Bjorn Andersson
2018-12-18 16:04   ` Sudeep Holla
2018-12-17 15:02 ` [PATCH v2 02/19] mailbox: arm-mhu: Use device-managed registration API Thierry Reding
2018-12-18 16:07   ` Sudeep Holla
2018-12-17 15:02 ` [PATCH v2 03/19] mailbox: bcm2835: " Thierry Reding
2018-12-18 19:24   ` Eric Anholt
2018-12-17 15:02 ` [PATCH v2 04/19] mailbox: bcm-flexrm: " Thierry Reding
2018-12-17 15:02 ` [PATCH v2 05/19] mailbox: bcm-pdc: " Thierry Reding
2018-12-17 15:02 ` [PATCH v2 06/19] mailbox: hi3660: " Thierry Reding
2018-12-18  9:16   ` leo.yan
2018-12-17 15:02 ` [PATCH v2 07/19] mailbox: hi6220: " Thierry Reding
2018-12-18  9:17   ` leo.yan
2018-12-17 15:02 ` [PATCH v2 08/19] mailbox: imx: " Thierry Reding
2018-12-17 15:31   ` Oleksij Rempel [this message]
2018-12-17 15:02 ` [PATCH v2 09/19] mailbox: altera: " Thierry Reding
2018-12-17 15:02 ` [PATCH v2 10/19] mailbox: sti: " Thierry Reding
2018-12-18  8:27   ` Lee Jones
2018-12-17 15:02 ` [PATCH v2 11/19] mailbox: xgene-slimpro: " Thierry Reding
2018-12-17 15:02 ` [PATCH v2 12/19] mailbox: mtk-cmdq: " Thierry Reding
2018-12-17 15:02 ` [PATCH v2 13/19] mailbox: mtk-cmdq: Remove needless devm_kfree() calls Thierry Reding
2018-12-17 15:02 ` [PATCH v2 14/19] mailbox: omap: Use device-managed registration API Thierry Reding
2018-12-18  0:10   ` kbuild test robot
2018-12-17 15:02 ` [PATCH v2 15/19] mailbox: platform-mhu: " Thierry Reding
2018-12-17 15:04   ` Neil Armstrong
2018-12-17 15:02 ` [PATCH v2 16/19] mailbox: qcom-apcs: " Thierry Reding
2018-12-17 18:16   ` Bjorn Andersson
2018-12-17 15:02 ` [PATCH v2 17/19] mailbox: rockchip: " Thierry Reding
2018-12-18  0:36   ` Caesar Wang
2018-12-17 15:02 ` [PATCH v2 18/19] mailbox: stm32-ipcc: " Thierry Reding
2018-12-18  8:26   ` Ludovic BARRE
2018-12-17 15:02 ` [PATCH v2 19/19] mailbox: ti-msgmgr: " Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217153108.ycu7xg25edzccv7g@pengutronix.de \
    --to=o.rempel@pengutronix.de \
    --cc=aisheng.dong@nxp.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®