Re: [PATCH v2 14/19] mailbox: omap: Use device-managed registration API

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3066 bytes --]

Hi Thierry,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.20-rc7 next-20181217]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Thierry-Reding/mailbox-Device-managed-registration/20181218-033546
config: arm-omap2plus_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/mailbox/omap-mailbox.c: In function 'omap_mbox_register':
>> drivers/mailbox/omap-mailbox.c:489:38: error: passing argument 1 of 'devm_mbox_controller_register' from incompatible pointer type [-Werror=incompatible-pointer-types]
     ret = devm_mbox_controller_register(&mdev->controller);
                                         ^
   In file included from drivers/mailbox/omap-mailbox.c:23:0:
   include/linux/mailbox_controller.h:134:5: note: expected 'struct device *' but argument is of type 'struct mbox_controller *'
    int devm_mbox_controller_register(struct device *dev,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mailbox/omap-mailbox.c:489:8: error: too few arguments to function 'devm_mbox_controller_register'
     ret = devm_mbox_controller_register(&mdev->controller);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/mailbox/omap-mailbox.c:23:0:
   include/linux/mailbox_controller.h:134:5: note: declared here
    int devm_mbox_controller_register(struct device *dev,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/devm_mbox_controller_register +489 drivers/mailbox/omap-mailbox.c

   463	
   464	static int omap_mbox_register(struct omap_mbox_device *mdev)
   465	{
   466		int ret;
   467		int i;
   468		struct omap_mbox **mboxes;
   469	
   470		if (!mdev || !mdev->mboxes)
   471			return -EINVAL;
   472	
   473		mboxes = mdev->mboxes;
   474		for (i = 0; mboxes[i]; i++) {
   475			struct omap_mbox *mbox = mboxes[i];
   476	
   477			mbox->dev = device_create(&omap_mbox_class, mdev->dev,
   478						0, mbox, "%s", mbox->name);
   479			if (IS_ERR(mbox->dev)) {
   480				ret = PTR_ERR(mbox->dev);
   481				goto err_out;
   482			}
   483		}
   484	
   485		mutex_lock(&omap_mbox_devices_lock);
   486		list_add(&mdev->elem, &omap_mbox_devices);
   487		mutex_unlock(&omap_mbox_devices_lock);
   488	
 > 489		ret = devm_mbox_controller_register(&mdev->controller);
   490	
   491	err_out:
   492		if (ret) {
   493			while (i--)
   494				device_unregister(mboxes[i]->dev);
   495		}
   496		return ret;
   497	}
   498	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34486 bytes --]