* [PATCH][next] gpiolib-acpi: remove unused variable 'err', cleans up build warning
@ 2018-12-18 12:28 Colin King
2018-12-18 12:44 ` Mika Westerberg
2018-12-21 10:31 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2018-12-18 12:28 UTC (permalink / raw)
To: Mika Westerberg, Andy Shevchenko, Linus Walleij,
Bartosz Golaszewski, linux-gpio, linux-acpi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable err is defined but never used. Remove it. Cleans up warning:
warning: unused variable ‘err’ [-Wunused-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpio/gpiolib-acpi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index fb0496e20ff8..259cf6ab969b 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -908,7 +908,6 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,
if (!found) {
enum gpiod_flags flags = acpi_gpio_to_gpiod_flags(agpio);
const char *label = "ACPI:OpRegion";
- int err;
desc = gpiochip_request_own_desc(chip, pin, label,
flags);
--
2.19.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] gpiolib-acpi: remove unused variable 'err', cleans up build warning
2018-12-18 12:28 [PATCH][next] gpiolib-acpi: remove unused variable 'err', cleans up build warning Colin King
@ 2018-12-18 12:44 ` Mika Westerberg
2018-12-21 10:31 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2018-12-18 12:44 UTC (permalink / raw)
To: Colin King
Cc: Andy Shevchenko, Linus Walleij, Bartosz Golaszewski, linux-gpio,
linux-acpi, kernel-janitors, linux-kernel
On Tue, Dec 18, 2018 at 12:28:02PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable err is defined but never used. Remove it. Cleans up warning:
>
> warning: unused variable ‘err’ [-Wunused-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] gpiolib-acpi: remove unused variable 'err', cleans up build warning
2018-12-18 12:28 [PATCH][next] gpiolib-acpi: remove unused variable 'err', cleans up build warning Colin King
2018-12-18 12:44 ` Mika Westerberg
@ 2018-12-21 10:31 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-12-21 10:31 UTC (permalink / raw)
To: Colin King
Cc: Mika Westerberg, Andy Shevchenko, Bartosz Golaszewski,
open list:GPIO SUBSYSTEM, ACPI Devel Maling List,
kernel-janitors, linux-kernel
On Tue, Dec 18, 2018 at 1:28 PM Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable err is defined but never used. Remove it. Cleans up warning:
>
> warning: unused variable ‘err’ [-Wunused-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied with Mika's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-21 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-18 12:28 [PATCH][next] gpiolib-acpi: remove unused variable 'err', cleans up build warning Colin King
2018-12-18 12:44 ` Mika Westerberg
2018-12-21 10:31 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®