* [PATCH 3/7] drm: omapdrm: Delete base.id prints
@ 2018-12-18 13:38 Shayenne Moura
2018-12-19 13:11 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Shayenne Moura @ 2018-12-18 13:38 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie
Cc: dri-devel, linux-kernel
This patch removes base.id prints from drm_display_mode
objects in omapdrm files. It removes dependency from drm_mode_object.
Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
---
drivers/gpu/drm/omapdrm/omap_connector.c | 4 ++--
drivers/gpu/drm/omapdrm/omap_crtc.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c b/drivers/gpu/drm/omapdrm/omap_connector.c
index b81302c4bf9e..e02986e0b2c6 100644
--- a/drivers/gpu/drm/omapdrm/omap_connector.c
+++ b/drivers/gpu/drm/omapdrm/omap_connector.c
@@ -306,9 +306,9 @@ static int omap_connector_mode_valid(struct drm_connector *connector,
done:
DBG("connector: mode %s: "
- "%d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
+ "\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
(ret == MODE_OK) ? "valid" : "invalid",
- mode->base.id, mode->name, mode->vrefresh, mode->clock,
+ mode->name, mode->vrefresh, mode->clock,
mode->hdisplay, mode->hsync_start,
mode->hsync_end, mode->htotal,
mode->vdisplay, mode->vsync_start,
diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omapdrm/omap_crtc.c
index caffc547ef97..3d6febb2e9c4 100644
--- a/drivers/gpu/drm/omapdrm/omap_crtc.c
+++ b/drivers/gpu/drm/omapdrm/omap_crtc.c
@@ -427,8 +427,8 @@ static void omap_crtc_mode_set_nofb(struct drm_crtc *crtc)
struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
struct drm_display_mode *mode = &crtc->state->adjusted_mode;
- DBG("%s: set mode: %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
- omap_crtc->name, mode->base.id, mode->name,
+ DBG("%s: set mode: \"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
+ omap_crtc->name, mode->name,
mode->vrefresh, mode->clock,
mode->hdisplay, mode->hsync_start, mode->hsync_end, mode->htotal,
mode->vdisplay, mode->vsync_start, mode->vsync_end, mode->vtotal,
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 3/7] drm: omapdrm: Delete base.id prints
2018-12-18 13:38 [PATCH 3/7] drm: omapdrm: Delete base.id prints Shayenne Moura
@ 2018-12-19 13:11 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2018-12-19 13:11 UTC (permalink / raw)
To: Shayenne Moura
Cc: Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie,
linux-kernel, dri-devel
On Tue, Dec 18, 2018 at 11:38:15AM -0200, Shayenne Moura wrote:
> This patch removes base.id prints from drm_display_mode
> objects in omapdrm files. It removes dependency from drm_mode_object.
>
> Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
Same comment as for msm, I think better to use this opportunity to switch
over to DRM_MODE_FMT/ARG.
-Daniel
> ---
> drivers/gpu/drm/omapdrm/omap_connector.c | 4 ++--
> drivers/gpu/drm/omapdrm/omap_crtc.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c b/drivers/gpu/drm/omapdrm/omap_connector.c
> index b81302c4bf9e..e02986e0b2c6 100644
> --- a/drivers/gpu/drm/omapdrm/omap_connector.c
> +++ b/drivers/gpu/drm/omapdrm/omap_connector.c
> @@ -306,9 +306,9 @@ static int omap_connector_mode_valid(struct drm_connector *connector,
>
> done:
> DBG("connector: mode %s: "
> - "%d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
> + "\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
> (ret == MODE_OK) ? "valid" : "invalid",
> - mode->base.id, mode->name, mode->vrefresh, mode->clock,
> + mode->name, mode->vrefresh, mode->clock,
> mode->hdisplay, mode->hsync_start,
> mode->hsync_end, mode->htotal,
> mode->vdisplay, mode->vsync_start,
> diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omapdrm/omap_crtc.c
> index caffc547ef97..3d6febb2e9c4 100644
> --- a/drivers/gpu/drm/omapdrm/omap_crtc.c
> +++ b/drivers/gpu/drm/omapdrm/omap_crtc.c
> @@ -427,8 +427,8 @@ static void omap_crtc_mode_set_nofb(struct drm_crtc *crtc)
> struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
> struct drm_display_mode *mode = &crtc->state->adjusted_mode;
>
> - DBG("%s: set mode: %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
> - omap_crtc->name, mode->base.id, mode->name,
> + DBG("%s: set mode: \"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
> + omap_crtc->name, mode->name,
> mode->vrefresh, mode->clock,
> mode->hdisplay, mode->hsync_start, mode->hsync_end, mode->htotal,
> mode->vdisplay, mode->vsync_start, mode->vsync_end, mode->vtotal,
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-19 13:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-18 13:38 [PATCH 3/7] drm: omapdrm: Delete base.id prints Shayenne Moura
2018-12-19 13:11 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®