mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* one liner DMA mapping fix for 4.20
@ 2018-12-22  8:21 Christoph Hellwig
  2018-12-22  8:21 ` [PATCH] dma-mapping: fix flags in dma_alloc_wc Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2018-12-22  8:21 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: iommu, linux-kernel

Hi Linus,

I'm sending this directly to you given how late we are.  This is a trivial
one liner fixing a regression I introduces in this merge merge, and which
has only been noticed by code inspection, but which is pretty obvious when
looking at the original commit.  It would be great if it could make 4.20.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] dma-mapping: fix flags in dma_alloc_wc
  2018-12-22  8:21 one liner DMA mapping fix for 4.20 Christoph Hellwig
@ 2018-12-22  8:21 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2018-12-22  8:21 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: iommu, linux-kernel

We really need the writecombine flag in dma_alloc_wc, fix a stupid
oversight.

Fixes: 7ed1d91a9e ("dma-mapping: translate __GFP_NOFAIL to DMA_ATTR_NO_WARN")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/dma-mapping.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 15bd41447025..d327bdd53716 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -796,7 +796,7 @@ static inline void dmam_release_declared_memory(struct device *dev)
 static inline void *dma_alloc_wc(struct device *dev, size_t size,
 				 dma_addr_t *dma_addr, gfp_t gfp)
 {
-	unsigned long attrs = DMA_ATTR_NO_WARN;
+	unsigned long attrs = DMA_ATTR_WRITE_COMBINE;
 
 	if (gfp & __GFP_NOWARN)
 		attrs |= DMA_ATTR_NO_WARN;
-- 
2.19.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-22 19:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-22  8:21 one liner DMA mapping fix for 4.20 Christoph Hellwig
2018-12-22  8:21 ` [PATCH] dma-mapping: fix flags in dma_alloc_wc Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®