From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Youlin Wang <wwx575822@notesmail.huawei.com>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>,
Zhuangluan Su <suzhuangluan@hisilicon.com>,
Ryan Grachek <ryan@edited.us>,
dmaengine@vger.kernel.org, Tanglei Han <hantanglei@huawei.com>
Subject: Re: [PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware
Date: Sat, 5 Jan 2019 11:18:41 +0530 [thread overview]
Message-ID: <20190105054841.GC3761@Mani-XPS-13-9360> (raw)
In-Reply-To: <CALAqxLV35NGGR4xZ-yvqLDuEqzhKTBvjAjBU+xBnyiGSAycW7Q@mail.gmail.com>
On Fri, Jan 04, 2019 at 09:44:17PM -0800, John Stultz wrote:
> On Fri, Jan 4, 2019 at 9:39 PM Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
> >
> > On Fri, Jan 04, 2019 at 09:22:46PM -0800, John Stultz wrote:
> > > On Fri, Jan 4, 2019 at 7:42 PM Manivannan Sadhasivam
> > > <manivannan.sadhasivam@linaro.org> wrote:
> > > > On Fri, Jan 04, 2019 at 12:56:23PM -0800, John Stultz wrote:
> > > > > From: Youlin Wang <wwx575822@notesmail.huawei.com>
> > > > >
> > > > > There is an new "hisi-pcm-asp-dma-1.0" device added in
> > > > > "arch/arm64/boot/dts/hisilicon/hi3660.dtsi".
> > > > > So we have to add a matching id in the driver file:
> > > > > .compatible = "hisilicon,hisi-pcm-asp-dma-1.0"
> > > > >
> > > > > And also hisi-pcm-asp dma device needs no setting to the clock.
> > > > > So we skip this by adding and using soc data flags.
> > > > >
> > > > > After above this driver will support both k3 and hisi_asp dma hardware.
> > > > >
> > > >
> > > > Small description about the hardware (ASP DMAC) would be really helpful.
> > >
> > > I've taken a shot at this (along with integrating your other feedback
> > > - thanks again for the review!), though as I don't have direct
> > > documentation, my knowledge is a bit second hand.
> > >
> > > See here:
> > > https://git.linaro.org/people/john.stultz/android-dev.git/commit/?h=dev/hikey960-mainline-WIP&id=754a79facf1af0b59a7f8fd63050da12ebf5521e
> > >
> > > Let me know if you have suggestions for more specific changes!
> >
> > Description looks good to me. But looks like you are not protecting the
> > other clk APIs like clk_prepare_enable and clk_disable_unprepare. Don't
> > they fail when the relevant clk is not found?
>
> No, those calls just return 0 if null clock is passed
>
> int clk_prepare(struct clk *clk)
> {
> if (!clk)
> return 0;
> ...
Ah, okay. Didn't look into the definition.
So with the change in description,
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
>
> thanks
> -john
next prev parent reply other threads:[~2019-01-05 5:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 20:56 [PATCH 0/8 v2] k3dma patches to add support for hi3660/HiKey960 John Stultz
2019-01-04 20:56 ` [PATCH 1/8 v2] Documentation: bindings: k3dma: Extend the k3dma driver binding to support hisi-asp John Stultz
2019-01-04 20:56 ` [PATCH 2/8 v2] Documentation: bindings: k3dma: Add binding for dma-avail-chan John Stultz
2019-01-05 4:00 ` Manivannan Sadhasivam
2019-01-05 4:39 ` John Stultz
2019-01-05 4:53 ` Manivannan Sadhasivam
2019-01-05 4:58 ` John Stultz
2019-01-05 13:46 ` Vinod Koul
2019-01-05 14:08 ` Manivannan Sadhasivam
2019-01-07 6:24 ` Vinod Koul
2019-01-04 20:56 ` [PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware John Stultz
2019-01-05 3:41 ` Manivannan Sadhasivam
2019-01-05 5:22 ` John Stultz
2019-01-05 5:39 ` Manivannan Sadhasivam
2019-01-05 5:44 ` John Stultz
2019-01-05 5:48 ` Manivannan Sadhasivam [this message]
2019-01-04 20:56 ` [PATCH 4/8 v2] dma: k3dma: Delete axi_config John Stultz
2019-01-05 3:44 ` Manivannan Sadhasivam
2019-01-04 20:56 ` [PATCH 5/8 v2] dma: k3dma: Add support to dma_avail_chan John Stultz
2019-01-04 20:56 ` [PATCH 6/8 v2] arm64: dts: hi3660: Add dma to uart nodes John Stultz
2019-01-05 3:49 ` Manivannan Sadhasivam
2019-01-05 4:34 ` John Stultz
2019-01-05 5:37 ` John Stultz
2019-01-04 20:56 ` [PATCH 7/8 v2] arm64: dts: hi3660: Add hisi asp dma device John Stultz
2019-01-05 3:50 ` Manivannan Sadhasivam
2019-01-04 20:56 ` [PATCH 8/8 v2] arm64: dts: hi3660: Fixup unofficial dma-min-chan to dma-avail-chan John Stultz
2019-01-05 3:37 ` [PATCH 0/8 v2] k3dma patches to add support for hi3660/HiKey960 Manivannan Sadhasivam
2019-01-05 4:28 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190105054841.GC3761@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=hantanglei@huawei.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ryan@edited.us \
--cc=suzhuangluan@hisilicon.com \
--cc=vkoul@kernel.org \
--cc=wwx575822@notesmail.huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®