From: "Andreas Färber" <afaerber@suse.de>
To: linux-lpwan@lists.infradead.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Andreas Färber" <afaerber@suse.de>,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH lora-next 01/11] net: lora: sx125x: Abort on wrong version
Date: Sun, 6 Jan 2019 09:37:44 +0100 [thread overview]
Message-ID: <20190106083754.6004-2-afaerber@suse.de> (raw)
In-Reply-To: <20190106083754.6004-1-afaerber@suse.de>
This helps detect issues such as the concentrator being in reset.
Enhance error output while at it.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
drivers/net/lora/sx125x.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/lora/sx125x.c b/drivers/net/lora/sx125x.c
index 90e7cdb9d1a8..0228d1f887a0 100644
--- a/drivers/net/lora/sx125x.c
+++ b/drivers/net/lora/sx125x.c
@@ -195,9 +195,13 @@ static int __maybe_unused sx125x_regmap_probe(struct device *dev, struct regmap
if (true) {
ret = regmap_read(priv->regmap, SX1255_VERSION, &val);
if (ret) {
- dev_err(dev, "version read failed\n");
+ dev_err(dev, "version read failed (%d)\n", ret);
return ret;
}
+ if (val != 0x21) {
+ dev_err(dev, "unexpected version: %u\n", val);
+ return -EINVAL;
+ }
dev_info(dev, "SX125x version: %02x\n", val);
}
--
2.16.4
next prev parent reply other threads:[~2019-01-06 8:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 8:37 [PATCH lora-next 00/11] net: lora: sx130x: Fixes for enabling regcache Andreas Färber
2019-01-06 8:37 ` Andreas Färber [this message]
2019-01-06 8:37 ` [PATCH lora-next 02/11] net: lora: sx130x: Fix error codes Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 03/11] net: lora: sx130x: Revert drop of sx1301_soft_reset() Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 04/11] net: lora: sx130x: Fix soft reset Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 05/11] net: lora: sx130x: Fix regmap field toggles Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 06/11] net: lora: sx130x: Force regmap field write before sleep Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 07/11] net: lora: sx130x: Force regmap field writes before function boundaries Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 08/11] net: lora: sx130x: Force regmap field write before reading status Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 09/11] net: lora: sx130x: Mark AGCSTS register as volatile Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 10/11] net: lora: sx130x: Mark MCU_CTRL " Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 11/11] net: lora: sx130x: Enable regmap caching Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190106083754.6004-2-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-lpwan@lists.infradead.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®