From: "Andreas Färber" <afaerber@suse.de>
To: linux-lpwan@lists.infradead.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Andreas Färber" <afaerber@suse.de>,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH lora-next 02/11] net: lora: sx130x: Fix error codes
Date: Sun, 6 Jan 2019 09:37:45 +0100 [thread overview]
Message-ID: <20190106083754.6004-3-afaerber@suse.de> (raw)
In-Reply-To: <20190106083754.6004-1-afaerber@suse.de>
Use of -ENXIO results in a misleading error message from ip command:
RTNETLINK answers: No such device or address
Switch to -EIO for more accurate description:
RTNETLINK answers: Input/output error
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
drivers/net/lora/sx130x.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/lora/sx130x.c b/drivers/net/lora/sx130x.c
index 88d4ce1aabcf..21db0ddb101f 100644
--- a/drivers/net/lora/sx130x.c
+++ b/drivers/net/lora/sx130x.c
@@ -353,7 +353,7 @@ static int sx130x_agc_calibrate(struct sx130x_priv *priv)
if (val != SX1301_MCU_AGC_CAL_FW_VERSION) {
dev_err(priv->dev, "unexpected firmware version, expecting %u\n",
SX1301_MCU_AGC_CAL_FW_VERSION);
- return -ENXIO;
+ return -EIO;
}
ret = sx130x_field_write(priv, F_EMERGENCY_FORCE_HOST_CTRL, 0);
@@ -380,7 +380,7 @@ static int sx130x_agc_calibrate(struct sx130x_priv *priv)
dev_info(priv->dev, "AGC status: %02x\n", (unsigned)val);
if ((val & (BIT(7) | BIT(0))) != (BIT(7) | BIT(0))) {
dev_err(priv->dev, "AGC calibration failed\n");
- return -ENXIO;
+ return -EIO;
}
return 0;
@@ -453,7 +453,7 @@ static int sx130x_load_all_firmware(struct sx130x_priv *priv)
if (val != SX1301_MCU_AGC_FW_VERSION) {
dev_err(priv->dev, "unexpected firmware version, expecting %u\n",
SX1301_MCU_AGC_FW_VERSION);
- return -ENXIO;
+ return -EIO;
}
ret = sx130x_arb_ram_read(priv, 0x20, &val);
@@ -467,7 +467,7 @@ static int sx130x_load_all_firmware(struct sx130x_priv *priv)
if (val != SX1301_MCU_ARB_FW_VERSION) {
dev_err(priv->dev, "unexpected firmware version, expecting %u\n",
SX1301_MCU_ARB_FW_VERSION);
- return -ENXIO;
+ return -EIO;
}
return 0;
@@ -636,7 +636,7 @@ int sx130x_probe(struct device *dev)
if (ver != SX1301_CHIP_VERSION) {
dev_err(dev, "unexpected version: %u\n", ver);
- return -ENXIO;
+ return -EIO;
}
ret = regmap_write(priv->regmap, SX1301_PAGE, 0);
--
2.16.4
next prev parent reply other threads:[~2019-01-06 8:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 8:37 [PATCH lora-next 00/11] net: lora: sx130x: Fixes for enabling regcache Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 01/11] net: lora: sx125x: Abort on wrong version Andreas Färber
2019-01-06 8:37 ` Andreas Färber [this message]
2019-01-06 8:37 ` [PATCH lora-next 03/11] net: lora: sx130x: Revert drop of sx1301_soft_reset() Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 04/11] net: lora: sx130x: Fix soft reset Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 05/11] net: lora: sx130x: Fix regmap field toggles Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 06/11] net: lora: sx130x: Force regmap field write before sleep Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 07/11] net: lora: sx130x: Force regmap field writes before function boundaries Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 08/11] net: lora: sx130x: Force regmap field write before reading status Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 09/11] net: lora: sx130x: Mark AGCSTS register as volatile Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 10/11] net: lora: sx130x: Mark MCU_CTRL " Andreas Färber
2019-01-06 8:37 ` [PATCH lora-next 11/11] net: lora: sx130x: Enable regmap caching Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190106083754.6004-3-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-lpwan@lists.infradead.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®