From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Elvira Khabirova <lineprinter@altlinux.org>,
Eugene Syromyatnikov <esyr@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Oleg Nesterov <oleg@redhat.com>,
Andy Lutomirski <luto@kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH v7 16/22] powerpc: define syscall_get_error()
Date: Mon, 7 Jan 2019 05:54:17 +0300 [thread overview]
Message-ID: <20190107025417.GP1207@altlinux.org> (raw)
In-Reply-To: <20190107025101.GA1182@altlinux.org>
syscall_get_error() is required to be implemented on this
architecture in addition to already implemented syscall_get_nr(),
syscall_get_arguments(), syscall_get_return_value(), and
syscall_get_arch() functions in order to extend the generic
ptrace API with PTRACE_GET_SYSCALL_INFO request.
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Elvira Khabirova <lineprinter@altlinux.org>
Cc: Eugene Syromyatnikov <esyr@redhat.com>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
Notes:
v7: unchanged
v6: unchanged
v5:
This change has been tested with
tools/testing/selftests/ptrace/get_syscall_info.c and strace,
so it's correct from PTRACE_GET_SYSCALL_INFO point of view.
This cast doubts on commit v4.3-rc1~86^2~81 that changed
syscall_set_return_value() in a way that doesn't quite match
syscall_get_error(), but syscall_set_return_value() is out
of scope of this series, so I'll just let you know my concerns.
arch/powerpc/include/asm/syscall.h | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/powerpc/include/asm/syscall.h b/arch/powerpc/include/asm/syscall.h
index 1a0e7a8b1c81..b522781ad7c0 100644
--- a/arch/powerpc/include/asm/syscall.h
+++ b/arch/powerpc/include/asm/syscall.h
@@ -38,6 +38,16 @@ static inline void syscall_rollback(struct task_struct *task,
regs->gpr[3] = regs->orig_gpr3;
}
+static inline long syscall_get_error(struct task_struct *task,
+ struct pt_regs *regs)
+{
+ /*
+ * If the system call failed,
+ * regs->gpr[3] contains a positive ERRORCODE.
+ */
+ return (regs->ccr & 0x10000000UL) ? -regs->gpr[3] : 0;
+}
+
static inline long syscall_get_return_value(struct task_struct *task,
struct pt_regs *regs)
{
--
ldv
next prev parent reply other threads:[~2019-01-07 2:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190107025101.GA1182@altlinux.org>
2019-01-07 2:52 ` [PATCH v7 01/22] asm-generic/syscall.h: prepare for inclusion by other files Dmitry V. Levin
2019-01-07 2:52 ` [PATCH v7 02/22] asm-generic/syscall.h: turn syscall_[gs]et_arguments into wrappers Dmitry V. Levin
2019-01-07 2:52 ` [PATCH v7 03/22] alpha: define remaining syscall_get_* functions Dmitry V. Levin
2019-01-07 7:25 ` kbuild test robot
2019-01-07 2:53 ` [PATCH v7 04/22] Move EM_ARCOMPACT and EM_ARCV2 to uapi/linux/elf-em.h Dmitry V. Levin
2019-01-07 2:53 ` [PATCH v7 05/22] arc: define syscall_get_arch() Dmitry V. Levin
2019-01-07 2:53 ` [PATCH v7 06/22] c6x: " Dmitry V. Levin
2019-01-07 2:53 ` [PATCH v7 07/22] h8300: define remaining syscall_get_* functions Dmitry V. Levin
2019-01-07 2:53 ` [PATCH v7 08/22] Move EM_HEXAGON to uapi/linux/elf-em.h Dmitry V. Levin
2019-01-07 2:53 ` [PATCH v7 09/22] hexagon: define remaining syscall_get_* functions Dmitry V. Levin
2019-01-07 2:53 ` [PATCH v7 10/22] Move EM_NDS32 to uapi/linux/elf-em.h Dmitry V. Levin
2019-01-07 2:53 ` [PATCH v7 11/22] nds32: define syscall_get_arch() Dmitry V. Levin
2019-01-07 2:53 ` [PATCH v7 12/22] nios2: " Dmitry V. Levin
2019-01-07 2:54 ` [PATCH v7 13/22] m68k: add asm/syscall.h Dmitry V. Levin
2019-01-07 2:54 ` [PATCH v7 14/22] mips: define syscall_get_error() Dmitry V. Levin
2019-01-07 2:54 ` [PATCH v7 15/22] parisc: " Dmitry V. Levin
2019-02-28 19:38 ` Dmitry V. Levin
2019-02-28 21:39 ` Helge Deller
2019-01-07 2:54 ` Dmitry V. Levin [this message]
2019-02-28 19:39 ` [PATCH v7 16/22] powerpc: " Dmitry V. Levin
2019-01-07 2:54 ` [PATCH v7 17/22] riscv: define syscall_get_arch() Dmitry V. Levin
2019-01-07 2:54 ` [PATCH v7 18/22] Move EM_UNICORE to uapi/linux/elf-em.h Dmitry V. Levin
2019-01-07 2:54 ` [PATCH v7 19/22] unicore32: add asm/syscall.h Dmitry V. Levin
2019-01-07 2:54 ` [PATCH v7 20/22] syscall_get_arch: add "struct task_struct *" argument Dmitry V. Levin
2019-01-07 2:54 ` [PATCH v7 21/22] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin
2019-01-07 7:05 ` kbuild test robot
2019-01-07 14:58 ` Dmitry V. Levin
[not found] ` <201901071430.4jk67u0s%fengguang.wu@intel.com>
2019-01-07 12:54 ` [PATCH] nds32: fix asm/syscall.h Dmitry V. Levin
2019-02-28 21:58 ` Dmitry V. Levin
2019-01-07 2:55 ` [PATCH v7 22/22] selftests/ptrace: add a test case for PTRACE_GET_SYSCALL_INFO Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107025417.GP1207@altlinux.org \
--to=ldv@altlinux.org \
--cc=benh@kernel.crashing.org \
--cc=esyr@redhat.com \
--cc=lineprinter@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome