mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Guan Xuetao <gxt@pku.edu.cn>
Cc: Elvira Khabirova <lineprinter@altlinux.org>,
	Eugene Syromyatnikov <esyr@redhat.com>,
	Paul Moore <paul@paul-moore.com>, Eric Paris <eparis@redhat.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Andy Lutomirski <luto@kernel.org>,
	linux-audit@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH v7 19/22] unicore32: add asm/syscall.h
Date: Mon, 7 Jan 2019 05:54:37 +0300	[thread overview]
Message-ID: <20190107025437.GS1207@altlinux.org> (raw)
In-Reply-To: <20190107025101.GA1182@altlinux.org>

syscall_get_* functions are required to be implemented on all
architectures in order to extend the generic ptrace API with
PTRACE_GET_SYSCALL_INFO request.

This introduces asm/syscall.h on unicore32 implementing all 5
syscall_get_* functions as documented in asm-generic/syscall.h:
syscall_get_nr, syscall_get_arguments, syscall_get_error,
syscall_get_return_value, and syscall_get_arch.

A note for the unicore32 architecture maintainer: I have no idea about
the syscall semantics on this architecture, and the code is of little
help here.  All I could infer from the code is that it looks very
similar to ARM, so the implementation of syscall_get_* functions
is also similar to ARM.

Acked-by: Paul Moore <paul@paul-moore.com> # audit related parts
Cc: Guan Xuetao <gxt@pku.edu.cn>
Cc: Eric Paris <eparis@redhat.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Elvira Khabirova <lineprinter@altlinux.org>
Cc: Eugene Syromyatnikov <esyr@redhat.com>
Cc: linux-audit@redhat.com
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---

Notes:
    v7: added Acked-by
    v6: made use of asm-generic/syscall.h
    v5: added syscall_get_nr, syscall_get_arguments, syscall_get_error,
        and syscall_get_return_value
    v1: added syscall_get_arch

 arch/unicore32/include/asm/syscall.h | 47 ++++++++++++++++++++++++++++
 include/uapi/linux/audit.h           |  1 +
 2 files changed, 48 insertions(+)
 create mode 100644 arch/unicore32/include/asm/syscall.h

diff --git a/arch/unicore32/include/asm/syscall.h b/arch/unicore32/include/asm/syscall.h
new file mode 100644
index 000000000000..267e97e256bd
--- /dev/null
+++ b/arch/unicore32/include/asm/syscall.h
@@ -0,0 +1,47 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _ASM_UNICORE_SYSCALL_H
+#define _ASM_UNICORE_SYSCALL_H
+
+#include <linux/err.h>
+#include <asm/ptrace.h>
+#include <asm-generic/syscall.h>
+#include <uapi/linux/audit.h>
+
+static inline int
+syscall_get_nr(struct task_struct *task, struct pt_regs *regs)
+{
+	return task_thread_info(task)->syscall;
+}
+
+static inline void
+__syscall_get_arguments(struct task_struct *task, struct pt_regs *regs,
+			unsigned int i, unsigned int n, unsigned long *args)
+{
+	if (i == 0) {
+		args[0] = regs->UCreg_ORIG_00;
+		args++;
+		i++;
+		n--;
+	}
+	memcpy(args, &regs->UCreg_00 + i, n * sizeof(args[0]));
+}
+
+static inline long
+syscall_get_error(struct task_struct *task, struct pt_regs *regs)
+{
+	return IS_ERR_VALUE(regs->UCreg_00) ? regs->UCreg_00 : 0;
+}
+
+static inline long
+syscall_get_return_value(struct task_struct *task, struct pt_regs *regs)
+{
+	return regs->UCreg_00;
+}
+
+static inline int
+syscall_get_arch(void)
+{
+	return AUDIT_ARCH_UNICORE;
+}
+
+#endif	/* _ASM_UNICORE_SYSCALL_H */
diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h
index bcc0619b046f..3901c51c0b93 100644
--- a/include/uapi/linux/audit.h
+++ b/include/uapi/linux/audit.h
@@ -424,6 +424,7 @@ enum {
 #define AUDIT_ARCH_TILEGX	(EM_TILEGX|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE)
 #define AUDIT_ARCH_TILEGX32	(EM_TILEGX|__AUDIT_ARCH_LE)
 #define AUDIT_ARCH_TILEPRO	(EM_TILEPRO|__AUDIT_ARCH_LE)
+#define AUDIT_ARCH_UNICORE	(EM_UNICORE|__AUDIT_ARCH_LE)
 #define AUDIT_ARCH_X86_64	(EM_X86_64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE)
 #define AUDIT_ARCH_XTENSA	(EM_XTENSA)
 
-- 
ldv

  parent reply	other threads:[~2019-01-07  2:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190107025101.GA1182@altlinux.org>
2019-01-07  2:52 ` [PATCH v7 01/22] asm-generic/syscall.h: prepare for inclusion by other files Dmitry V. Levin
2019-01-07  2:52 ` [PATCH v7 02/22] asm-generic/syscall.h: turn syscall_[gs]et_arguments into wrappers Dmitry V. Levin
2019-01-07  2:52 ` [PATCH v7 03/22] alpha: define remaining syscall_get_* functions Dmitry V. Levin
2019-01-07  7:25   ` kbuild test robot
2019-01-07  2:53 ` [PATCH v7 04/22] Move EM_ARCOMPACT and EM_ARCV2 to uapi/linux/elf-em.h Dmitry V. Levin
2019-01-07  2:53 ` [PATCH v7 05/22] arc: define syscall_get_arch() Dmitry V. Levin
2019-01-07  2:53 ` [PATCH v7 06/22] c6x: " Dmitry V. Levin
2019-01-07  2:53 ` [PATCH v7 07/22] h8300: define remaining syscall_get_* functions Dmitry V. Levin
2019-01-07  2:53 ` [PATCH v7 08/22] Move EM_HEXAGON to uapi/linux/elf-em.h Dmitry V. Levin
2019-01-07  2:53 ` [PATCH v7 09/22] hexagon: define remaining syscall_get_* functions Dmitry V. Levin
2019-01-07  2:53 ` [PATCH v7 10/22] Move EM_NDS32 to uapi/linux/elf-em.h Dmitry V. Levin
2019-01-07  2:53 ` [PATCH v7 11/22] nds32: define syscall_get_arch() Dmitry V. Levin
2019-01-07  2:53 ` [PATCH v7 12/22] nios2: " Dmitry V. Levin
2019-01-07  2:54 ` [PATCH v7 13/22] m68k: add asm/syscall.h Dmitry V. Levin
2019-01-07  2:54 ` [PATCH v7 14/22] mips: define syscall_get_error() Dmitry V. Levin
2019-01-07  2:54 ` [PATCH v7 15/22] parisc: " Dmitry V. Levin
2019-02-28 19:38   ` Dmitry V. Levin
2019-02-28 21:39     ` Helge Deller
2019-01-07  2:54 ` [PATCH v7 16/22] powerpc: " Dmitry V. Levin
2019-02-28 19:39   ` Dmitry V. Levin
2019-01-07  2:54 ` [PATCH v7 17/22] riscv: define syscall_get_arch() Dmitry V. Levin
2019-01-07  2:54 ` [PATCH v7 18/22] Move EM_UNICORE to uapi/linux/elf-em.h Dmitry V. Levin
2019-01-07  2:54 ` Dmitry V. Levin [this message]
2019-01-07  2:54 ` [PATCH v7 20/22] syscall_get_arch: add "struct task_struct *" argument Dmitry V. Levin
2019-01-07  2:54 ` [PATCH v7 21/22] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin
2019-01-07  7:05   ` kbuild test robot
2019-01-07 14:58     ` Dmitry V. Levin
     [not found]   ` <201901071430.4jk67u0s%fengguang.wu@intel.com>
2019-01-07 12:54     ` [PATCH] nds32: fix asm/syscall.h Dmitry V. Levin
2019-02-28 21:58       ` Dmitry V. Levin
2019-01-07  2:55 ` [PATCH v7 22/22] selftests/ptrace: add a test case for PTRACE_GET_SYSCALL_INFO Dmitry V. Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190107025437.GS1207@altlinux.org \
    --to=ldv@altlinux.org \
    --cc=eparis@redhat.com \
    --cc=esyr@redhat.com \
    --cc=gxt@pku.edu.cn \
    --cc=lineprinter@altlinux.org \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=oleg@redhat.com \
    --cc=paul@paul-moore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome