* [PATCH v2] staging: erofs: Add identifier for function definition arguments
@ 2019-01-08 13:24 Sidong Yang
2019-01-08 17:05 ` Gao Xiang
2019-01-09 6:29 ` Chao Yu
0 siblings, 2 replies; 3+ messages in thread
From: Sidong Yang @ 2019-01-08 13:24 UTC (permalink / raw)
To: Gao Xiang
Cc: Sidong Yang, Chao Yu, Greg Kroah-Hartman, linux-erofs, devel,
linux-kernel
Add identifier for function definition arguments in xattr_iter_handlers,
this change clears the checkpatch.pl issue and make code more explicit.
Signed-off-by: Sidong Yang <realwakka@gmail.com>
---
drivers/staging/erofs/xattr.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
index 80dca6a4adbe..59bc5641c4e7 100644
--- a/drivers/staging/erofs/xattr.c
+++ b/drivers/staging/erofs/xattr.c
@@ -117,10 +117,12 @@ static int init_inode_xattrs(struct inode *inode)
* and need to be handled
*/
struct xattr_iter_handlers {
- int (*entry)(struct xattr_iter *, struct erofs_xattr_entry *);
- int (*name)(struct xattr_iter *, unsigned int, char *, unsigned int);
- int (*alloc_buffer)(struct xattr_iter *, unsigned int);
- void (*value)(struct xattr_iter *, unsigned int, char *, unsigned int);
+ int (*entry)(struct xattr_iter *_it, struct erofs_xattr_entry *entry);
+ int (*name)(struct xattr_iter *_it, unsigned int processed, char *buf,
+ unsigned int len);
+ int (*alloc_buffer)(struct xattr_iter *_it, unsigned int value_sz);
+ void (*value)(struct xattr_iter *_it, unsigned int processed, char *buf,
+ unsigned int len);
};
static inline int xattr_iter_fixup(struct xattr_iter *it)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] staging: erofs: Add identifier for function definition arguments
2019-01-08 13:24 [PATCH v2] staging: erofs: Add identifier for function definition arguments Sidong Yang
@ 2019-01-08 17:05 ` Gao Xiang
2019-01-09 6:29 ` Chao Yu
1 sibling, 0 replies; 3+ messages in thread
From: Gao Xiang @ 2019-01-08 17:05 UTC (permalink / raw)
To: Sidong Yang
Cc: Gao Xiang, devel, Greg Kroah-Hartman, Chao Yu, linux-kernel, linux-erofs
On 2019/1/8 21:24, Sidong Yang wrote:
> Add identifier for function definition arguments in xattr_iter_handlers,
> this change clears the checkpatch.pl issue and make code more explicit.
>
> Signed-off-by: Sidong Yang <realwakka@gmail.com>
personally looks good to me.
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: erofs: Add identifier for function definition arguments
2019-01-08 13:24 [PATCH v2] staging: erofs: Add identifier for function definition arguments Sidong Yang
2019-01-08 17:05 ` Gao Xiang
@ 2019-01-09 6:29 ` Chao Yu
1 sibling, 0 replies; 3+ messages in thread
From: Chao Yu @ 2019-01-09 6:29 UTC (permalink / raw)
To: Sidong Yang, Gao Xiang
Cc: Greg Kroah-Hartman, linux-erofs, devel, linux-kernel
On 2019/1/8 21:24, Sidong Yang wrote:
> Add identifier for function definition arguments in xattr_iter_handlers,
> this change clears the checkpatch.pl issue and make code more explicit.
>
> Signed-off-by: Sidong Yang <realwakka@gmail.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-09 6:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08 13:24 [PATCH v2] staging: erofs: Add identifier for function definition arguments Sidong Yang
2019-01-08 17:05 ` Gao Xiang
2019-01-09 6:29 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®