From: Hedi Berriche <hedi.berriche@hpe.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Hedi Berriche <hedi.berriche@hpe.com>
Subject: [PATCH 0/3] Protect against concurrent calls into UV BIOS
Date: Wed, 9 Jan 2019 10:45:38 +0000 [thread overview]
Message-ID: <20190109104541.25733-1-hedi.berriche@hpe.com> (raw)
Calls into UV BIOS were not being serialised which is wrong as it violates
EFI runtime rules, and bad as it does result in all sorts of potentially
hard to track down hangs and panics when efi_scratch gets clobbered.
Patch #1 makes the efi_runtime_lock semaphore visible to EFI runtime
callers defined outside drivers/firmware/efi/runtime-wrappers.c in
preparation for using it to serialise calls into UV BIOS.
Patch #2 removes uv_bios_call_reentrant() because it's dead code.
Patch #3 makes uv_bios_call() variants use efi_runtime_sem to protect
against concurrency.
Hedi Berriche (3):
efi/x86: turn EFI runtime semaphore into a global lock
x86/platform/UV: kill uv_bios_call_reentrant() as it has no callers
x86/platform/UV: use efi_runtime_sem to serialise BIOS calls
arch/x86/include/asm/uv/bios.h | 4 +-
arch/x86/platform/uv/bios_uv.c | 37 +++++++++++--------
drivers/firmware/efi/runtime-wrappers.c | 60 ++++++++++++++++----------------
include/linux/efi.h | 3 +
4 files changed, 57 insertions(+), 47 deletions(-)
--
2.20.0
next reply other threads:[~2019-01-09 10:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 10:45 Hedi Berriche [this message]
2019-01-09 10:45 ` [PATCH 1/3] efi/x86: turn EFI runtime semaphore into a global lock Hedi Berriche
2019-01-15 18:55 ` Thomas Gleixner
2019-01-15 19:35 ` Hedi Berriche
2019-01-26 14:03 ` Ard Biesheuvel
2019-01-09 10:45 ` [PATCH 2/3] x86/platform/UV: kill uv_bios_call_reentrant() as it has no callers Hedi Berriche
2019-01-26 14:04 ` Ard Biesheuvel
2019-01-09 10:45 ` [PATCH 3/3] x86/platform/UV: use efi_runtime_sem to serialise BIOS calls Hedi Berriche
2019-01-10 7:13 ` Bhupesh Sharma
2019-01-14 11:30 ` Hedi Berriche
2019-01-26 14:10 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109104541.25733-1-hedi.berriche@hpe.com \
--to=hedi.berriche@hpe.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®