From: Christoph Hellwig <hch@infradead.org>
To: wangbo <wdjjwb@163.com>
Cc: linux-kernel@vger.kernel.org, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, wang.bo116@zte.com.cn,
Ondrej Zary <linux@rainbow-software.org>
Subject: Re: [PATCH] scsi: wd719x Replace GFP_KERNEL with GFP_ATOMIC in wd719x_chip_init
Date: Mon, 14 Jan 2019 07:29:43 -0800 [thread overview]
Message-ID: <20190114152943.GA10454@infradead.org> (raw)
In-Reply-To: <1547479489-11560-1-git-send-email-wdjjwb@163.com>
On Mon, Jan 14, 2019 at 11:24:49PM +0800, wangbo wrote:
> wd719x_host_reset get spinlock first then call wd719x_chip_init,
> so replace GFP_KERNEL with GFP_ATOMIC in wd719x_chip_init.
Please move the allocation outside the lock instead. GFP_ATOMIC
DMA allocations are generally a bad idea and should be avoided where
we can.
More importantly we should never actually trigger the allocation
under the lock as far as fw_virt will always be set already
in that case.
So I think you can safely move the request firmware + allocation
+ memcpy from wd719x_chip_init to wd719x_board_found, but I'd rather
have Ondrej review that plan.
next prev parent reply other threads:[~2019-01-14 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 15:24 wangbo
2019-01-14 15:29 ` Christoph Hellwig [this message]
2019-01-14 16:31 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114152943.GA10454@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=martin.petersen@oracle.com \
--cc=wang.bo116@zte.com.cn \
--cc=wdjjwb@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®