* [PATCH] blkcg: annotate implicit fall through
@ 2019-01-14 20:31 Mathieu Malaterre
2019-03-13 20:26 ` Mathieu Malaterre
2019-03-13 20:31 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2019-01-14 20:31 UTC (permalink / raw)
To: Jens Axboe
Cc: Mathieu Malaterre, Steven Rostedt, Ingo Molnar, linux-block,
linux-kernel
There is a plan to build the kernel with -Wimplicit-fallthrough and
this place in the code produced a warning (W=1).
This commit remove the following warning:
kernel/trace/blktrace.c:725:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
kernel/trace/blktrace.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index fac0ddf8a8e2..e1c6d79fb4cc 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -723,6 +723,7 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg)
#endif
case BLKTRACESTART:
start = 1;
+ /* fall through */
case BLKTRACESTOP:
ret = __blk_trace_startstop(q, start);
break;
--
2.19.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blkcg: annotate implicit fall through
2019-01-14 20:31 [PATCH] blkcg: annotate implicit fall through Mathieu Malaterre
@ 2019-03-13 20:26 ` Mathieu Malaterre
2019-03-13 20:31 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2019-03-13 20:26 UTC (permalink / raw)
To: Jens Axboe
Cc: Steven Rostedt, Ingo Molnar, linux-block, LKML, Gustavo A. R. Silva
ping ?
On Mon, Jan 14, 2019 at 9:31 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
>
> This commit remove the following warning:
>
> kernel/trace/blktrace.c:725:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> kernel/trace/blktrace.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index fac0ddf8a8e2..e1c6d79fb4cc 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -723,6 +723,7 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg)
> #endif
> case BLKTRACESTART:
> start = 1;
> + /* fall through */
> case BLKTRACESTOP:
> ret = __blk_trace_startstop(q, start);
> break;
> --
> 2.19.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blkcg: annotate implicit fall through
2019-01-14 20:31 [PATCH] blkcg: annotate implicit fall through Mathieu Malaterre
2019-03-13 20:26 ` Mathieu Malaterre
@ 2019-03-13 20:31 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2019-03-13 20:31 UTC (permalink / raw)
To: Mathieu Malaterre; +Cc: Steven Rostedt, Ingo Molnar, linux-block, linux-kernel
On 1/14/19 1:31 PM, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
>
> This commit remove the following warning:
>
> kernel/trace/blktrace.c:725:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-13 20:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 20:31 [PATCH] blkcg: annotate implicit fall through Mathieu Malaterre
2019-03-13 20:26 ` Mathieu Malaterre
2019-03-13 20:31 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®