From: Qian Cai <cai@lca.pw>
To: pbonzini@redhat.com, rkrcmar@redhat.com
Cc: sean.j.christopherson@intel.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Qian Cai <cai@lca.pw>
Subject: [PATCH] kvm: add proper frame pointer logic for vmx
Date: Tue, 15 Jan 2019 01:44:59 -0500 [thread overview]
Message-ID: <20190115064459.70513-1-cai@lca.pw> (raw)
compilation warning since v5.0-rc1,
arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_vcpu_run.part.17()+0x3171:
call without frame pointer save/setup
Fixes: 453eafbe65f (KVM: VMX: Move VM-Enter + VM-Exit handling to
non-inline sub-routines)
Signed-off-by: Qian Cai <cai@lca.pw>
---
arch/x86/kvm/vmx/vmenter.S | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx/vmenter.S b/arch/x86/kvm/vmx/vmenter.S
index bcef2c7e9bc4..874dd3030dee 100644
--- a/arch/x86/kvm/vmx/vmenter.S
+++ b/arch/x86/kvm/vmx/vmenter.S
@@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0 */
#include <linux/linkage.h>
#include <asm/asm.h>
+#include <asm/frame.h>
.text
@@ -20,18 +21,22 @@
*/
ENTRY(vmx_vmenter)
/* EFLAGS.ZF is set if VMCS.LAUNCHED == 0 */
+ FRAME_BEGIN
je 2f
1: vmresume
+ FRAME_END
ret
2: vmlaunch
+ FRAME_END
ret
3: cmpb $0, kvm_rebooting
jne 4f
call kvm_spurious_fault
-4: ret
+4: FRAME_END
+ ret
.pushsection .fixup, "ax"
5: jmp 3b
--
2.17.2 (Apple Git-113)
next reply other threads:[~2019-01-15 6:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 6:44 Qian Cai [this message]
2019-01-15 7:04 ` Qian Cai
2019-01-15 7:13 ` Paolo Bonzini
2019-01-15 16:34 ` Sean Christopherson
2019-01-15 16:54 ` Qian Cai
2019-01-15 16:43 ` Qian Cai
2019-01-15 17:31 ` Qian Cai
2019-01-15 17:48 ` Sean Christopherson
2019-01-15 17:49 ` Sean Christopherson
2019-01-15 18:29 ` Qian Cai
2019-01-15 19:06 ` Sean Christopherson
2019-01-15 19:08 ` Sean Christopherson
2019-01-15 22:38 ` Josh Poimboeuf
2019-01-16 0:54 ` Sean Christopherson
2019-01-16 14:56 ` Josh Poimboeuf
2019-01-16 16:35 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115064459.70513-1-cai@lca.pw \
--to=cai@lca.pw \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®