From: Paolo Bonzini <pbonzini@redhat.com>
To: Qian Cai <cai@lca.pw>, rkrcmar@redhat.com
Cc: sean.j.christopherson@intel.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm: add proper frame pointer logic for vmx
Date: Tue, 15 Jan 2019 08:13:22 +0100 [thread overview]
Message-ID: <5109b3c2-cac0-aa19-9cc7-801340afe198@redhat.com> (raw)
In-Reply-To: <a6477022-bbc0-fc00-2c8e-75007b468d3f@lca.pw>
On 15/01/19 08:04, Qian Cai wrote:
>
>
> On 1/15/19 1:44 AM, Qian Cai wrote:
>> compilation warning since v5.0-rc1,
>>
>> arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_vcpu_run.part.17()+0x3171:
>> call without frame pointer save/setup
>>
>> Fixes: 453eafbe65f (KVM: VMX: Move VM-Enter + VM-Exit handling to
>> non-inline sub-routines)
>
> Oops, wrong fix. Back to square one.
>
Hmm, maybe like this:
diff --git a/arch/x86/kvm/vmx/vmenter.S b/arch/x86/kvm/vmx/vmenter.S
index bcef2c7e9bc4..33122fa9d4bd 100644
--- a/arch/x86/kvm/vmx/vmenter.S
+++ b/arch/x86/kvm/vmx/vmenter.S
@@ -26,19 +26,17 @@ ENTRY(vmx_vmenter)
ret
2: vmlaunch
+3:
ret
-3: cmpb $0, kvm_rebooting
- jne 4f
- call kvm_spurious_fault
-4: ret
-
.pushsection .fixup, "ax"
-5: jmp 3b
+4: cmpb $0, kvm_rebooting
+ jne 3b
+ jmp kvm_spurious_fault
.popsection
- _ASM_EXTABLE(1b, 5b)
- _ASM_EXTABLE(2b, 5b)
+ _ASM_EXTABLE(1b, 4b)
+ _ASM_EXTABLE(2b, 4b)
ENDPROC(vmx_vmenter)
Paolo
next prev parent reply other threads:[~2019-01-15 7:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 6:44 Qian Cai
2019-01-15 7:04 ` Qian Cai
2019-01-15 7:13 ` Paolo Bonzini [this message]
2019-01-15 16:34 ` Sean Christopherson
2019-01-15 16:54 ` Qian Cai
2019-01-15 16:43 ` Qian Cai
2019-01-15 17:31 ` Qian Cai
2019-01-15 17:48 ` Sean Christopherson
2019-01-15 17:49 ` Sean Christopherson
2019-01-15 18:29 ` Qian Cai
2019-01-15 19:06 ` Sean Christopherson
2019-01-15 19:08 ` Sean Christopherson
2019-01-15 22:38 ` Josh Poimboeuf
2019-01-16 0:54 ` Sean Christopherson
2019-01-16 14:56 ` Josh Poimboeuf
2019-01-16 16:35 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5109b3c2-cac0-aa19-9cc7-801340afe198@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=cai@lca.pw \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®