* linux-next: build warning after merge of the gpio-brgl tree
@ 2019-01-24 4:18 Stephen Rothwell
2019-01-24 5:42 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2019-01-24 4:18 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Linux Next Mailing List, Linux Kernel Mailing List, YueHaibing
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
Hi Bartosz,
After merging the gpio-brgl tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/gpio/gpio-davinci.c: In function 'davinci_gpio_get_irq_chip':
drivers/gpio/gpio-davinci.c:472:9: warning: function returns address of local variable [-Wreturn-local-addr]
return &gpio_unbanked.chip;
^~~~~~~~~~~~~~~~~~~
drivers/gpio/gpio-davinci.c: In function 'keystone_gpio_get_irq_chip':
drivers/gpio/gpio-davinci.c:480:9: warning: function returns address of local variable [-Wreturn-local-addr]
return &gpio_unbanked;
^~~~~~~~~~~~~~
Introduced by commit
ee5e87158e63 ("gpio: davinci: drop pointless static qualifier")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-next: build warning after merge of the gpio-brgl tree
2019-01-24 4:18 linux-next: build warning after merge of the gpio-brgl tree Stephen Rothwell
@ 2019-01-24 5:42 ` YueHaibing
2019-01-27 12:30 ` Bartosz Golaszewski
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2019-01-24 5:42 UTC (permalink / raw)
To: Stephen Rothwell, Bartosz Golaszewski
Cc: Linux Next Mailing List, Linux Kernel Mailing List
On 2019/1/24 12:18, Stephen Rothwell wrote:
> Hi Bartosz,
>
> After merging the gpio-brgl tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/gpio/gpio-davinci.c: In function 'davinci_gpio_get_irq_chip':
> drivers/gpio/gpio-davinci.c:472:9: warning: function returns address of local variable [-Wreturn-local-addr]
> return &gpio_unbanked.chip;
> ^~~~~~~~~~~~~~~~~~~
> drivers/gpio/gpio-davinci.c: In function 'keystone_gpio_get_irq_chip':
> drivers/gpio/gpio-davinci.c:480:9: warning: function returns address of local variable [-Wreturn-local-addr]
> return &gpio_unbanked;
> ^~~~~~~~~~~~~~
>
> Introduced by commit
>
> ee5e87158e63 ("gpio: davinci: drop pointless static qualifier")
I'm very sorry for this.
I misread the code, Pls revert this.
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-next: build warning after merge of the gpio-brgl tree
2019-01-24 5:42 ` YueHaibing
@ 2019-01-27 12:30 ` Bartosz Golaszewski
0 siblings, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2019-01-27 12:30 UTC (permalink / raw)
To: YueHaibing
Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List
czw., 24 sty 2019 o 06:42 YueHaibing <yuehaibing@huawei.com> napisał(a):
>
> On 2019/1/24 12:18, Stephen Rothwell wrote:
> > Hi Bartosz,
> >
> > After merging the gpio-brgl tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > drivers/gpio/gpio-davinci.c: In function 'davinci_gpio_get_irq_chip':
> > drivers/gpio/gpio-davinci.c:472:9: warning: function returns address of local variable [-Wreturn-local-addr]
> > return &gpio_unbanked.chip;
> > ^~~~~~~~~~~~~~~~~~~
> > drivers/gpio/gpio-davinci.c: In function 'keystone_gpio_get_irq_chip':
> > drivers/gpio/gpio-davinci.c:480:9: warning: function returns address of local variable [-Wreturn-local-addr]
> > return &gpio_unbanked;
> > ^~~~~~~~~~~~~~
> >
> > Introduced by commit
> >
> > ee5e87158e63 ("gpio: davinci: drop pointless static qualifier")
>
> I'm very sorry for this.
>
> I misread the code, Pls revert this.
>
> >
>
I backed out this one.
Thanks,
Bartosz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-27 12:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-24 4:18 linux-next: build warning after merge of the gpio-brgl tree Stephen Rothwell
2019-01-24 5:42 ` YueHaibing
2019-01-27 12:30 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®