mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Pingfan Liu <kernelfans@gmail.com>,
	kexec@lists.infradead.org, Baoquan He <bhe@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>,
	yinghai@kernel.org, vgoyal@redhat.com,
	Randy Dunlap <rdunlap@infradead.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv7] x86/kdump: bugfix, make the behavior of crashkernel=X consistent with kaslr
Date: Mon, 28 Jan 2019 17:58:09 +0800	[thread overview]
Message-ID: <20190128095809.GC3732@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <20190125140823.GC27998@zn.tnic>

On 01/25/19 at 03:08pm, Borislav Petkov wrote:
> On Fri, Jan 25, 2019 at 09:45:18PM +0800, Dave Young wrote:
> > AFAIK, some people prefer to explictly reserve crash memory at high
> > region even if it is possible to reserve at low area.  May because
> > <4G memory is limited on large server, they want to leave this for other
> > use. 
> > 
> > Yinghai or Vivek should know more about the history, probably they can
> > recall some initial reason.
> 
> Yes, just "prefer" is not good enough. There should be a technical
> reason why that's there.
> 
> Also, if the user doesn't care, then the code should be free to force
> "high" and thus probe a different range for allocation.

Another reason is in case ,high we will need automatically reserve a
region in low area for swiotlb.  So for example one use
crashkernel=256M,high,  actual reserved memory is 256M above 4G and
another 256M under 4G for swiotlb.  Normally it is not necessary for
most people.  Thus we can not make ,high as default.

Thanks
Dave

  reply	other threads:[~2019-01-28  9:58 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21  5:16 Pingfan Liu
2019-01-21  6:24 ` Baoquan He
2019-01-25 10:39 ` Borislav Petkov
2019-01-25 13:45   ` Dave Young
2019-01-25 14:08     ` Borislav Petkov
2019-01-28  9:58       ` Dave Young [this message]
2019-01-28 10:18         ` Borislav Petkov
2019-06-07 17:30           ` Borislav Petkov
2019-06-10  6:51             ` Dave Young
2019-01-29  5:25       ` Pingfan Liu
2019-01-31  7:42         ` Dave Young
2019-01-31  7:59       ` Dave Young
2019-01-31 10:57         ` Borislav Petkov
2019-01-31 22:27           ` Jerry Hoemann
2019-01-31 23:47             ` Borislav Petkov
2019-02-04 22:30               ` Jerry Hoemann
2019-02-05  8:15                 ` Borislav Petkov
2019-02-06 12:08                   ` Dave Young
2019-02-11 20:48                     ` Dave Young
2019-02-12  5:35                       ` Pingfan Liu
2019-02-15 10:24                       ` Borislav Petkov
2019-02-18  1:48                         ` Dave Young
2019-02-20  7:38                           ` Pingfan Liu
2019-02-20  8:32                           ` Borislav Petkov
2019-02-20  9:41                             ` Dave Young
2019-02-20 12:51                               ` Pingfan Liu
2019-02-21 17:13                               ` Borislav Petkov
2019-02-22  2:11                                 ` Dave Young
2019-02-22  8:42                                   ` Joerg Roedel
2019-02-22 13:00                                     ` Borislav Petkov
2019-02-24 13:25                                       ` Pingfan Liu
2019-02-25  1:53                                         ` Dave Young
2019-02-25  9:39                                         ` Borislav Petkov
2019-02-25 11:00                                       ` Joerg Roedel
2019-02-25 11:12                                         ` Dave Young
2019-02-25 11:30                                           ` Borislav Petkov
2019-03-01  3:04                                             ` Pingfan Liu
2019-03-01  3:19                                               ` Pingfan Liu
2019-03-22  8:22                                                 ` Dave Young
2019-01-29  5:51   ` Pingfan Liu
2019-01-31 10:50     ` Borislav Petkov
  -- strict thread matches above, loose matches on Subject: below --
2019-01-15  8:07 Pingfan Liu
2019-01-18  3:43 ` Dave Young
2019-01-19  1:25 ` Jerry Hoemann
2019-01-21  5:11   ` Pingfan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190128095809.GC3732@dhcp-128-65.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=kernelfans@gmail.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®