mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>, Joerg Roedel <jroedel@suse.de>,
	Baoquan He <bhe@redhat.com>,
	Jerry Hoemann <jerry.hoemann@hpe.com>,
	x86@kernel.org, Randy Dunlap <rdunlap@infradead.org>,
	kexec@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Yinghai Lu <yinghai@kernel.org>,
	vgoyal@redhat.com, iommu@lists.linux-foundation.org,
	konrad.wilk@oracle.com
Subject: Re: [PATCHv7] x86/kdump: bugfix, make the behavior of crashkernel=X consistent with kaslr
Date: Fri, 22 Mar 2019 16:22:16 +0800	[thread overview]
Message-ID: <20190322082216.GA23356@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <CAFgQCTs9pJ=3Jt1YLv6RmBWeViH8cmuMcKG+2Aj-Vo2Kh-Wcog@mail.gmail.com>

Hi Pingfan, 

Thanks for the effort,
On 03/01/19 at 11:19am, Pingfan Liu wrote:
> On Fri, Mar 1, 2019 at 11:04 AM Pingfan Liu <kernelfans@gmail.com> wrote:
> >
> > Hi Borislav,
> >
> > Do you think the following patch is good at present?
> > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> > index 81f9d23..9213073 100644
> > --- a/arch/x86/kernel/setup.c
> > +++ b/arch/x86/kernel/setup.c
> > @@ -460,7 +460,7 @@ static void __init
> > memblock_x86_reserve_range_setup_data(void)
> >  # define CRASH_ADDR_LOW_MAX    (512 << 20)
> >  # define CRASH_ADDR_HIGH_MAX   (512 << 20)
> >  #else
> > -# define CRASH_ADDR_LOW_MAX    (896UL << 20)
> > +# define CRASH_ADDR_LOW_MAX    (1 << 32)
> >  # define CRASH_ADDR_HIGH_MAX   MAXMEM
> >  #endif
> >
> Or patch lools like:
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 3d872a5..ed0def5 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -459,7 +459,7 @@ static void __init
> memblock_x86_reserve_range_setup_data(void)
>  # define CRASH_ADDR_LOW_MAX    (512 << 20)
>  # define CRASH_ADDR_HIGH_MAX   (512 << 20)
>  #else
> -# define CRASH_ADDR_LOW_MAX    (896UL << 20)
> +# define CRASH_ADDR_LOW_MAX    (1 << 32)
>  # define CRASH_ADDR_HIGH_MAX   MAXMEM
>  #endif
> 
> @@ -551,6 +551,15 @@ static void __init reserve_crashkernel(void)
>                                                     high ? CRASH_ADDR_HIGH_MAX
>                                                          : CRASH_ADDR_LOW_MAX,
>                                                     crash_size, CRASH_ALIGN);
> +#ifdef CONFIG_X86_64
> +               /*
> +                * crashkernel=X reserve below 4G fails? Try MAXMEM
> +                */
> +               if (!high && !crash_base)
> +                       crash_base = memblock_find_in_range(CRASH_ALIGN,
> +                                               CRASH_ADDR_HIGH_MAX,
> +                                               crash_size, CRASH_ALIGN);
> +#endif
> 
> which tries 0-4G, the fall back to 4G above

This way looks good to me, I will do some testing with old kexec-tools,
Once testing done I can take up this again and repost later with some documentation
update.  Also will split to 2 patches  one to drop the old limitation,
another for the fallback.

Thanks
Dave

  reply	other threads:[~2019-03-22  8:22 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21  5:16 Pingfan Liu
2019-01-21  6:24 ` Baoquan He
2019-01-25 10:39 ` Borislav Petkov
2019-01-25 13:45   ` Dave Young
2019-01-25 14:08     ` Borislav Petkov
2019-01-28  9:58       ` Dave Young
2019-01-28 10:18         ` Borislav Petkov
2019-06-07 17:30           ` Borislav Petkov
2019-06-10  6:51             ` Dave Young
2019-01-29  5:25       ` Pingfan Liu
2019-01-31  7:42         ` Dave Young
2019-01-31  7:59       ` Dave Young
2019-01-31 10:57         ` Borislav Petkov
2019-01-31 22:27           ` Jerry Hoemann
2019-01-31 23:47             ` Borislav Petkov
2019-02-04 22:30               ` Jerry Hoemann
2019-02-05  8:15                 ` Borislav Petkov
2019-02-06 12:08                   ` Dave Young
2019-02-11 20:48                     ` Dave Young
2019-02-12  5:35                       ` Pingfan Liu
2019-02-15 10:24                       ` Borislav Petkov
2019-02-18  1:48                         ` Dave Young
2019-02-20  7:38                           ` Pingfan Liu
2019-02-20  8:32                           ` Borislav Petkov
2019-02-20  9:41                             ` Dave Young
2019-02-20 12:51                               ` Pingfan Liu
2019-02-21 17:13                               ` Borislav Petkov
2019-02-22  2:11                                 ` Dave Young
2019-02-22  8:42                                   ` Joerg Roedel
2019-02-22 13:00                                     ` Borislav Petkov
2019-02-24 13:25                                       ` Pingfan Liu
2019-02-25  1:53                                         ` Dave Young
2019-02-25  9:39                                         ` Borislav Petkov
2019-02-25 11:00                                       ` Joerg Roedel
2019-02-25 11:12                                         ` Dave Young
2019-02-25 11:30                                           ` Borislav Petkov
2019-03-01  3:04                                             ` Pingfan Liu
2019-03-01  3:19                                               ` Pingfan Liu
2019-03-22  8:22                                                 ` Dave Young [this message]
2019-01-29  5:51   ` Pingfan Liu
2019-01-31 10:50     ` Borislav Petkov
  -- strict thread matches above, loose matches on Subject: below --
2019-01-15  8:07 Pingfan Liu
2019-01-18  3:43 ` Dave Young
2019-01-19  1:25 ` Jerry Hoemann
2019-01-21  5:11   ` Pingfan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190322082216.GA23356@dhcp-128-65.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jerry.hoemann@hpe.com \
    --cc=jroedel@suse.de \
    --cc=kernelfans@gmail.com \
    --cc=kexec@lists.infradead.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®