* [PATCH] ext2: Remove useless reset code
@ 2019-01-25 14:01 Liu Xiang
2019-01-28 14:48 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Liu Xiang @ 2019-01-25 14:01 UTC (permalink / raw)
To: jack; +Cc: linux-ext4, linux-kernel, liuxiang_1999, Liu Xiang
If ((char *)de == dir_end) is true, the name_len will not be used
in the subsequent routine. So the reset code can be removed.
Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
---
fs/ext2/dir.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext2/dir.c b/fs/ext2/dir.c
index 3b8114d..5ec497f 100644
--- a/fs/ext2/dir.c
+++ b/fs/ext2/dir.c
@@ -517,7 +517,6 @@ int ext2_add_link (struct dentry *dentry, struct inode *inode)
while ((char *)de <= kaddr) {
if ((char *)de == dir_end) {
/* We hit i_size */
- name_len = 0;
rec_len = chunk_size;
de->rec_len = ext2_rec_len_to_disk(chunk_size);
de->inode = 0;
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ext2: Remove useless reset code
2019-01-25 14:01 [PATCH] ext2: Remove useless reset code Liu Xiang
@ 2019-01-28 14:48 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2019-01-28 14:48 UTC (permalink / raw)
To: Liu Xiang; +Cc: jack, linux-ext4, linux-kernel, liuxiang_1999
On Fri 25-01-19 22:01:04, Liu Xiang wrote:
> If ((char *)de == dir_end) is true, the name_len will not be used
> in the subsequent routine. So the reset code can be removed.
>
> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
Thanks for the patch. I agree with your analysis but I prefer to keep the
code as is - it prevents warnings about uninitialized variable being used
for compilers than cannot infer that and also for humans reading the code
is easier this way.
Honza
> ---
> fs/ext2/dir.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext2/dir.c b/fs/ext2/dir.c
> index 3b8114d..5ec497f 100644
> --- a/fs/ext2/dir.c
> +++ b/fs/ext2/dir.c
> @@ -517,7 +517,6 @@ int ext2_add_link (struct dentry *dentry, struct inode *inode)
> while ((char *)de <= kaddr) {
> if ((char *)de == dir_end) {
> /* We hit i_size */
> - name_len = 0;
> rec_len = chunk_size;
> de->rec_len = ext2_rec_len_to_disk(chunk_size);
> de->inode = 0;
> --
> 1.9.1
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-28 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-25 14:01 [PATCH] ext2: Remove useless reset code Liu Xiang
2019-01-28 14:48 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®