mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mq: Make GPC default interrupt parent
@ 2019-01-31 20:45 Andrey Smirnov
  2019-01-31 21:47 ` Fabio Estevam
  0 siblings, 1 reply; 3+ messages in thread
From: Andrey Smirnov @ 2019-01-31 20:45 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Andrey Smirnov, Fabio Estevam, Chris Healy, Lucas Stach,
	Leonard Crestez, A.s. Dong, Richard Zhu, linux-imx,
	linux-arm-kernel, linux-kernel

Now that the GPCv2 driver supports i.MX8MQ, make GPC default interrupt
parent.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Leonard Crestez <leonard.crestez@nxp.com>
Cc: "A.s. Dong" <aisheng.dong@nxp.com>
Cc: Richard Zhu <hongxing.zhu@nxp.com>
Cc: linux-imx@nxp.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index d20e5c7e21a3..e9aa64156577 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -12,8 +12,7 @@
 #include "imx8mq-pinfunc.h"
 
 / {
-	/* This should really be the GPC, but we need a driver for this first */
-	interrupt-parent = <&gic>;
+	interrupt-parent = <&gpc>;
 
 	#address-cells = <2>;
 	#size-cells = <2>;
@@ -265,6 +264,11 @@
 				compatible = "fsl,imx8mq-gpc";
 				reg = <0x303a0000 0x10000>;
 
+				interrupt-controller;
+				interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
+				#interrupt-cells = <3>;
+				interrupt-parent = <&gic>;
+
 				pgc {
 					#address-cells = <1>;
 					#size-cells = <0>;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8mq: Make GPC default interrupt parent
  2019-01-31 20:45 [PATCH] arm64: dts: imx8mq: Make GPC default interrupt parent Andrey Smirnov
@ 2019-01-31 21:47 ` Fabio Estevam
  2019-02-01  0:13   ` Andrey Smirnov
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2019-01-31 21:47 UTC (permalink / raw)
  To: Andrey Smirnov
  Cc: Shawn Guo, A.s. Dong, Richard Zhu,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel, NXP Linux Team, Fabio Estevam, Leonard Crestez,
	Chris Healy, Lucas Stach

Hi Andrey

On Thu, Jan 31, 2019 at 7:11 PM Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
>
> Now that the GPCv2 driver supports i.MX8MQ, make GPC default interrupt
> parent.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>

Lucas has already submitted this same change and another one that
selects the GPC driver as part of a series.

My feedback was to send the GPC selection patch first in order to
avoid boot hang when people try to boot without the GPC driver
selected.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8mq: Make GPC default interrupt parent
  2019-01-31 21:47 ` Fabio Estevam
@ 2019-02-01  0:13   ` Andrey Smirnov
  0 siblings, 0 replies; 3+ messages in thread
From: Andrey Smirnov @ 2019-02-01  0:13 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Shawn Guo, A.s. Dong, Richard Zhu,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel, NXP Linux Team, Fabio Estevam, Leonard Crestez,
	Chris Healy, Lucas Stach

On Thu, Jan 31, 2019 at 1:47 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Andrey
>
> On Thu, Jan 31, 2019 at 7:11 PM Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
> >
> > Now that the GPCv2 driver supports i.MX8MQ, make GPC default interrupt
> > parent.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>
> Lucas has already submitted this same change and another one that
> selects the GPC driver as part of a series.
>

OK, good to know. Please disregard this patch, then.

Thanks,
Andrey Smirnov

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-01  0:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-31 20:45 [PATCH] arm64: dts: imx8mq: Make GPC default interrupt parent Andrey Smirnov
2019-01-31 21:47 ` Fabio Estevam
2019-02-01  0:13   ` Andrey Smirnov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®