* Re: [PATCH] iommu/ipmmu-vmsa: fix device reference leaks [not found] <HK0PR02MB3634F6AE1FAE6B86EF82B291B26C0@HK0PR02MB3634.apcprd02.prod.outlook.com> @ 2019-02-11 10:24 ` joro 2019-02-12 16:47 ` Laurent Pinchart 0 siblings, 1 reply; 2+ messages in thread From: joro @ 2019-02-11 10:24 UTC (permalink / raw) To: wen yang; +Cc: iommu, linux-kernel, Laurent Pinchart, Magnus Damm Adding a few more people to Cc. On Sun, Feb 03, 2019 at 10:27:09AM +0000, wen yang wrote: > Make sure to drop the reference to the device taken by > of_find_device_by_node() on driver unbind. > > Signed-off-by: Wen Yang <yellowriver2010@hotmail.com> > Cc: Joerg Roedel <joro@8bytes.org> > Cc: iommu@lists.linux-foundation.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/iommu/ipmmu-vmsa.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c > index 7a4529c..cebf56d 100644 > --- a/drivers/iommu/ipmmu-vmsa.c > +++ b/drivers/iommu/ipmmu-vmsa.c > @@ -756,6 +756,9 @@ static int ipmmu_init_platform_device(struct device *dev, > > fwspec->iommu_priv = platform_get_drvdata(ipmmu_pdev); > > + if (!fwspec->iommu_priv) > + put_device(&ipmmu_pdev->dev); > + > return 0; > } > > -- > 2.7.4 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iommu/ipmmu-vmsa: fix device reference leaks 2019-02-11 10:24 ` [PATCH] iommu/ipmmu-vmsa: fix device reference leaks joro @ 2019-02-12 16:47 ` Laurent Pinchart 0 siblings, 0 replies; 2+ messages in thread From: Laurent Pinchart @ 2019-02-12 16:47 UTC (permalink / raw) To: joro; +Cc: wen yang, iommu, linux-kernel, Laurent Pinchart, Magnus Damm Hello, Wen, thank you for the patch. On Mon, Feb 11, 2019 at 11:24:15AM +0100, joro@8bytes.org wrote: > Adding a few more people to Cc. > > On Sun, Feb 03, 2019 at 10:27:09AM +0000, wen yang wrote: > > Make sure to drop the reference to the device taken by > > of_find_device_by_node() on driver unbind. > > > > Signed-off-by: Wen Yang <yellowriver2010@hotmail.com> > > Cc: Joerg Roedel <joro@8bytes.org> > > Cc: iommu@lists.linux-foundation.org > > Cc: linux-kernel@vger.kernel.org > > --- > > drivers/iommu/ipmmu-vmsa.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c > > index 7a4529c..cebf56d 100644 > > --- a/drivers/iommu/ipmmu-vmsa.c > > +++ b/drivers/iommu/ipmmu-vmsa.c > > @@ -756,6 +756,9 @@ static int ipmmu_init_platform_device(struct device *dev, > > > > fwspec->iommu_priv = platform_get_drvdata(ipmmu_pdev); > > > > + if (!fwspec->iommu_priv) > > + put_device(&ipmmu_pdev->dev); > > + This doesn't seem to match the patch's subject, and doesn't seem to fix the problem. > > return 0; > > } > > -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-12 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <HK0PR02MB3634F6AE1FAE6B86EF82B291B26C0@HK0PR02MB3634.apcprd02.prod.outlook.com>
2019-02-11 10:24 ` [PATCH] iommu/ipmmu-vmsa: fix device reference leaks joro
2019-02-12 16:47 ` Laurent Pinchart
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®