From: Konrad Rzeszutek Wilk <konrad@darnok.org>
To: Christoph Hellwig <hch@lst.de>
Cc: pjones@redhat.com, konrad@kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iscsi_ibft: use virt_to_phys instead of isa_virt_to_bus
Date: Tue, 12 Feb 2019 13:46:16 -0500 [thread overview]
Message-ID: <20190212184611.GA19464@localhost.localdomain> (raw)
In-Reply-To: <20190211134642.31149-1-hch@lst.de>
On Mon, Feb 11, 2019 at 02:46:42PM +0100, Christoph Hellwig wrote:
> As far as I can tell IBFT is a firmware table and has nothing to do with
> the good old ISA bus. And even if it the two would be the same on x86
> anyway. So remove the isa_virt_to_bus call in preparation of eventually
> removing that API entirely.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Queued it up in https://git.kernel.org/pub/scm/linux/kernel/git/konrad/ibft.git
> ---
> drivers/firmware/iscsi_ibft_find.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/iscsi_ibft_find.c b/drivers/firmware/iscsi_ibft_find.c
> index 72d9ea18270b..85c656d04bb0 100644
> --- a/drivers/firmware/iscsi_ibft_find.c
> +++ b/drivers/firmware/iscsi_ibft_find.c
> @@ -104,7 +104,7 @@ unsigned long __init find_ibft_region(unsigned long *sizep)
>
> if (ibft_addr) {
> *sizep = PAGE_ALIGN(ibft_addr->header.length);
> - return (u64)isa_virt_to_bus(ibft_addr);
> + return (u64)virt_to_phys(ibft_addr);
> }
>
> *sizep = 0;
> --
> 2.20.1
>
prev parent reply other threads:[~2019-02-12 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 13:46 Christoph Hellwig
2019-02-12 18:46 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212184611.GA19464@localhost.localdomain \
--to=konrad@darnok.org \
--cc=hch@lst.de \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®