* [PATCH] iscsi_ibft: use virt_to_phys instead of isa_virt_to_bus
@ 2019-02-11 13:46 Christoph Hellwig
2019-02-12 18:46 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2019-02-11 13:46 UTC (permalink / raw)
To: pjones, konrad; +Cc: x86, linux-kernel
As far as I can tell IBFT is a firmware table and has nothing to do with
the good old ISA bus. And even if it the two would be the same on x86
anyway. So remove the isa_virt_to_bus call in preparation of eventually
removing that API entirely.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/firmware/iscsi_ibft_find.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/iscsi_ibft_find.c b/drivers/firmware/iscsi_ibft_find.c
index 72d9ea18270b..85c656d04bb0 100644
--- a/drivers/firmware/iscsi_ibft_find.c
+++ b/drivers/firmware/iscsi_ibft_find.c
@@ -104,7 +104,7 @@ unsigned long __init find_ibft_region(unsigned long *sizep)
if (ibft_addr) {
*sizep = PAGE_ALIGN(ibft_addr->header.length);
- return (u64)isa_virt_to_bus(ibft_addr);
+ return (u64)virt_to_phys(ibft_addr);
}
*sizep = 0;
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iscsi_ibft: use virt_to_phys instead of isa_virt_to_bus
2019-02-11 13:46 [PATCH] iscsi_ibft: use virt_to_phys instead of isa_virt_to_bus Christoph Hellwig
@ 2019-02-12 18:46 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Rzeszutek Wilk @ 2019-02-12 18:46 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: pjones, konrad, x86, linux-kernel
On Mon, Feb 11, 2019 at 02:46:42PM +0100, Christoph Hellwig wrote:
> As far as I can tell IBFT is a firmware table and has nothing to do with
> the good old ISA bus. And even if it the two would be the same on x86
> anyway. So remove the isa_virt_to_bus call in preparation of eventually
> removing that API entirely.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Queued it up in https://git.kernel.org/pub/scm/linux/kernel/git/konrad/ibft.git
> ---
> drivers/firmware/iscsi_ibft_find.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/iscsi_ibft_find.c b/drivers/firmware/iscsi_ibft_find.c
> index 72d9ea18270b..85c656d04bb0 100644
> --- a/drivers/firmware/iscsi_ibft_find.c
> +++ b/drivers/firmware/iscsi_ibft_find.c
> @@ -104,7 +104,7 @@ unsigned long __init find_ibft_region(unsigned long *sizep)
>
> if (ibft_addr) {
> *sizep = PAGE_ALIGN(ibft_addr->header.length);
> - return (u64)isa_virt_to_bus(ibft_addr);
> + return (u64)virt_to_phys(ibft_addr);
> }
>
> *sizep = 0;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-12 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 13:46 [PATCH] iscsi_ibft: use virt_to_phys instead of isa_virt_to_bus Christoph Hellwig
2019-02-12 18:46 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®