From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Colin Ian King <colin.king@canonical.com>,
"David S . Miller" <davem@davemloft.net>,
Sasha Levin <sashal@kernel.org>,
netdev@vger.kernel.org
Subject: [PATCH AUTOSEL 3.18 12/14] atm: he: fix sign-extension overflow on large shift
Date: Tue, 12 Feb 2019 21:41:36 -0500 [thread overview]
Message-ID: <20190213024139.22268-12-sashal@kernel.org> (raw)
In-Reply-To: <20190213024139.22268-1-sashal@kernel.org>
From: Colin Ian King <colin.king@canonical.com>
[ Upstream commit cb12d72b27a6f41325ae23a11033cf5fedfa1b97 ]
Shifting the 1 by exp by an int can lead to sign-extension overlow when
exp is 31 since 1 is an signed int and sign-extending this result to an
unsigned long long will set the upper 32 bits. Fix this by shifting an
unsigned long.
Detected by cppcheck:
(warning) Shifting signed 32-bit value by 31 bits is undefined behaviour
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/atm/he.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/he.c b/drivers/atm/he.c
index c39702bc279d..937f54ccbe6b 100644
--- a/drivers/atm/he.c
+++ b/drivers/atm/he.c
@@ -717,7 +717,7 @@ static int he_init_cs_block_rcm(struct he_dev *he_dev)
instead of '/ 512', use '>> 9' to prevent a call
to divdu3 on x86 platforms
*/
- rate_cps = (unsigned long long) (1 << exp) * (man + 512) >> 9;
+ rate_cps = (unsigned long long) (1UL << exp) * (man + 512) >> 9;
if (rate_cps < 10)
rate_cps = 10; /* 2.2.1 minimum payload rate is 10 cps */
--
2.19.1
next prev parent reply other threads:[~2019-02-13 2:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 2:41 [PATCH AUTOSEL 3.18 01/14] mfd: ti_am335x_tscadc: Use PLATFORM_DEVID_AUTO while registering mfd cells Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 02/14] mfd: twl-core: Fix section annotations on {,un}protect_pm_master Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 03/14] mfd: db8500-prcmu: Fix some section annotations Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 04/14] mfd: ab8500-core: Return zero in get_register_interruptible() Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 05/14] mfd: wm5110: Add missing ASRC rate register Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 06/14] mfd: mc13xxx: Fix a missing check of a register-read failure Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 07/14] MIPS: ath79: Enable OF serial ports in the default config Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 08/14] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 09/14] scsi: isci: initialize shost fully before calling scsi_add_host() Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 10/14] MIPS: jazz: fix 64bit build Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 11/14] isdn: i4l: isdn_tty: Fix some concurrency double-free bugs Sasha Levin
2019-02-13 2:41 ` Sasha Levin [this message]
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 13/14] leds: lp5523: fix a missing check of return value of lp55xx_read Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 14/14] isdn: avm: Fix string plus integer warning from Clang Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213024139.22268-12-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®