From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: YueHaibing <yuehaibing@huawei.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Sasha Levin <sashal@kernel.org>,
linux-scsi@vger.kernel.org
Subject: [PATCH AUTOSEL 3.18 08/14] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param
Date: Tue, 12 Feb 2019 21:41:32 -0500 [thread overview]
Message-ID: <20190213024139.22268-8-sashal@kernel.org> (raw)
In-Reply-To: <20190213024139.22268-1-sashal@kernel.org>
From: YueHaibing <yuehaibing@huawei.com>
[ Upstream commit 72b4a0465f995175a2e22cf4a636bf781f1f28a7 ]
The return code should be check while qla4xxx_copy_from_fwddb_param fails.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/scsi/qla4xxx/ql4_os.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index d0cad6fc598e..a9fac1eb8306 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -7251,6 +7251,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct scsi_qla_host *ha,
rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn,
fw_ddb_entry);
+ if (rc)
+ goto free_sess;
ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n",
__func__, fnode_sess->dev.kobj.name);
--
2.19.1
next prev parent reply other threads:[~2019-02-13 2:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 2:41 [PATCH AUTOSEL 3.18 01/14] mfd: ti_am335x_tscadc: Use PLATFORM_DEVID_AUTO while registering mfd cells Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 02/14] mfd: twl-core: Fix section annotations on {,un}protect_pm_master Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 03/14] mfd: db8500-prcmu: Fix some section annotations Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 04/14] mfd: ab8500-core: Return zero in get_register_interruptible() Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 05/14] mfd: wm5110: Add missing ASRC rate register Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 06/14] mfd: mc13xxx: Fix a missing check of a register-read failure Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 07/14] MIPS: ath79: Enable OF serial ports in the default config Sasha Levin
2019-02-13 2:41 ` Sasha Levin [this message]
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 09/14] scsi: isci: initialize shost fully before calling scsi_add_host() Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 10/14] MIPS: jazz: fix 64bit build Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 11/14] isdn: i4l: isdn_tty: Fix some concurrency double-free bugs Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 12/14] atm: he: fix sign-extension overflow on large shift Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 13/14] leds: lp5523: fix a missing check of return value of lp55xx_read Sasha Levin
2019-02-13 2:41 ` [PATCH AUTOSEL 3.18 14/14] isdn: avm: Fix string plus integer warning from Clang Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213024139.22268-8-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®