From: Greg KH <gregkh@linuxfoundation.org>
To: Vaishali Thakkar <vaishali.thakkar@linaro.org>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
rafael@kernel.org, bjorn.andersson@linaro.org, vkoul@kernel.org
Subject: Re: [PATCH 3/5] soc: qcom: socinfo: Expose custom attributes
Date: Thu, 14 Feb 2019 10:41:06 +0100 [thread overview]
Message-ID: <20190214094106.GA10895@kroah.com> (raw)
In-Reply-To: <297ee5e7840077f0330d4ae02dcd13c2ad97f910.1550114271.git.vaishali.thakkar@linaro.org>
On Thu, Feb 14, 2019 at 09:11:49AM +0530, Vaishali Thakkar wrote:
> +static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo)
> +{
> + qcom_socinfo->dbg_root = debugfs_create_dir("qcom_socinfo", NULL);
> +
> + if (!qcom_socinfo->dbg_root) {
> + pr_err("Cannot create debugfs directory\n");
> + return;
> + }
No need to check this at all, just call debugfs_create_dir() and be done
with it.
> +
> + DEBUGFS_UINT_ADD(raw_version);
> + DEBUGFS_UINT_ADD(hardware_platform);
> + DEBUGFS_UINT_ADD(platform_version);
> + DEBUGFS_UINT_ADD(foundry_id);
> + DEBUGFS_HEX_ADD(chip_family);
> + DEBUGFS_HEX_ADD(raw_device_family);
> + DEBUGFS_HEX_ADD(raw_device_number);
> + DEBUGFS_ADD(build_id);
> + DEBUGFS_ADD(accessory_chip);
> + DEBUGFS_ADD(pmic_model);
> + DEBUGFS_ADD(platform_subtype);
> + DEBUGFS_ADD(pmic_die_revision);
> +}
> +
> +static void socinfo_debugfs_exit(struct qcom_socinfo *qcom_socinfo)
> +{
> + debugfs_remove_recursive(qcom_socinfo->dbg_root);
> +}
> +#else
> +socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo) { return 0; }
> +socinfo_debugfs_exit(struct qcom_socinfo *qcom_socinfo) { return 0; }
These function signatures do not match the ones above :(
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-14 9:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 3:41 [PATCH 0/5] soc: qcom: Add SoC info driver Vaishali Thakkar
2019-02-14 3:41 ` [PATCH 1/5] base: soc: Add serial_number attribute to soc Vaishali Thakkar
2019-02-14 9:54 ` Rafael J. Wysocki
2019-02-14 3:41 ` [PATCH 2/5] soc: qcom: Add socinfo driver Vaishali Thakkar
2019-02-14 3:41 ` [PATCH 3/5] soc: qcom: socinfo: Expose custom attributes Vaishali Thakkar
2019-02-14 4:52 ` Joe Perches
2019-02-14 9:41 ` Greg KH [this message]
2019-02-14 3:42 ` [PATCH 4/5] soc: qcom: socinfo: Expose image information Vaishali Thakkar
2019-02-14 3:42 ` [PATCH 5/5] base: soc: Export soc_device_register/unregister APIs Vaishali Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214094106.GA10895@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=vaishali.thakkar@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome