From: Joe Perches <joe@perches.com>
To: Vaishali Thakkar <vaishali.thakkar@linaro.org>, andy.gross@linaro.org
Cc: david.brown@linaro.org, gregkh@linuxfoundation.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
rafael@kernel.org, bjorn.andersson@linaro.org, vkoul@kernel.org
Subject: Re: [PATCH 3/5] soc: qcom: socinfo: Expose custom attributes
Date: Wed, 13 Feb 2019 20:52:28 -0800 [thread overview]
Message-ID: <7da4c05d211ed71795bcbad0ded3614979a664c6.camel@perches.com> (raw)
In-Reply-To: <297ee5e7840077f0330d4ae02dcd13c2ad97f910.1550114271.git.vaishali.thakkar@linaro.org>
On Thu, 2019-02-14 at 09:11 +0530, Vaishali Thakkar wrote:
> The Qualcomm socinfo provides a number of additional attributes,
> add these to the socinfo driver and expose them via debugfs
> functionality.
trivia:
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
[]
> @@ -70,6 +93,10 @@ struct socinfo {
> struct qcom_socinfo {
> struct soc_device *soc_dev;
> struct soc_device_attribute attr;
> + #ifdef CONFIG_DEBUG_FS
> + struct dentry *dbg_root;
> + #endif /* CONFIG_DEBUG_FS */
It's generally better to move the #ifdef/#endif to column 1
next prev parent reply other threads:[~2019-02-14 4:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 3:41 [PATCH 0/5] soc: qcom: Add SoC info driver Vaishali Thakkar
2019-02-14 3:41 ` [PATCH 1/5] base: soc: Add serial_number attribute to soc Vaishali Thakkar
2019-02-14 9:54 ` Rafael J. Wysocki
2019-02-14 3:41 ` [PATCH 2/5] soc: qcom: Add socinfo driver Vaishali Thakkar
2019-02-14 3:41 ` [PATCH 3/5] soc: qcom: socinfo: Expose custom attributes Vaishali Thakkar
2019-02-14 4:52 ` Joe Perches [this message]
2019-02-14 9:41 ` Greg KH
2019-02-14 3:42 ` [PATCH 4/5] soc: qcom: socinfo: Expose image information Vaishali Thakkar
2019-02-14 3:42 ` [PATCH 5/5] base: soc: Export soc_device_register/unregister APIs Vaishali Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7da4c05d211ed71795bcbad0ded3614979a664c6.camel@perches.com \
--to=joe@perches.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=vaishali.thakkar@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®