* [PATCH 1/3] regulator: pv88060: Fix array out-of-bounds access
@ 2019-02-19 10:00 Axel Lin
2019-02-19 10:00 ` [PATCH 2/3] regulator: pv88080: " Axel Lin
2019-02-19 10:00 ` [PATCH 3/3] regulator: pv88090: " Axel Lin
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2019-02-19 10:00 UTC (permalink / raw)
To: Mark Brown; +Cc: James Ban, Liam Girdwood, linux-kernel, Axel Lin
Fix off-by-one while iterating current_limits array.
The valid index should be 0 ~ n_current_limits -1.
Fixes: f307a7e9b7af ("regulator: pv88060: new regulator driver")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/pv88060-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/pv88060-regulator.c b/drivers/regulator/pv88060-regulator.c
index d5dab9bef378..da6ed723e398 100644
--- a/drivers/regulator/pv88060-regulator.c
+++ b/drivers/regulator/pv88060-regulator.c
@@ -135,7 +135,7 @@ static int pv88060_set_current_limit(struct regulator_dev *rdev, int min,
int i;
/* search for closest to maximum */
- for (i = info->n_current_limits; i >= 0; i--) {
+ for (i = info->n_current_limits - 1; i >= 0; i--) {
if (min <= info->current_limits[i]
&& max >= info->current_limits[i]) {
return regmap_update_bits(rdev->regmap,
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 2/3] regulator: pv88080: Fix array out-of-bounds access
2019-02-19 10:00 [PATCH 1/3] regulator: pv88060: Fix array out-of-bounds access Axel Lin
@ 2019-02-19 10:00 ` Axel Lin
2019-02-19 10:00 ` [PATCH 3/3] regulator: pv88090: " Axel Lin
1 sibling, 0 replies; 3+ messages in thread
From: Axel Lin @ 2019-02-19 10:00 UTC (permalink / raw)
To: Mark Brown; +Cc: James Ban, Liam Girdwood, linux-kernel, Axel Lin
Fix off-by-one while iterating current_limits array.
The valid index should be 0 ~ n_current_limits -1.
Fixes: 99cf3af5e2d5 ("regulator: pv88080: new regulator driver")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/pv88080-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/pv88080-regulator.c b/drivers/regulator/pv88080-regulator.c
index 9a08cb2de501..6770e4de2097 100644
--- a/drivers/regulator/pv88080-regulator.c
+++ b/drivers/regulator/pv88080-regulator.c
@@ -279,7 +279,7 @@ static int pv88080_set_current_limit(struct regulator_dev *rdev, int min,
int i;
/* search for closest to maximum */
- for (i = info->n_current_limits; i >= 0; i--) {
+ for (i = info->n_current_limits - 1; i >= 0; i--) {
if (min <= info->current_limits[i]
&& max >= info->current_limits[i]) {
return regmap_update_bits(rdev->regmap,
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 3/3] regulator: pv88090: Fix array out-of-bounds access
2019-02-19 10:00 [PATCH 1/3] regulator: pv88060: Fix array out-of-bounds access Axel Lin
2019-02-19 10:00 ` [PATCH 2/3] regulator: pv88080: " Axel Lin
@ 2019-02-19 10:00 ` Axel Lin
1 sibling, 0 replies; 3+ messages in thread
From: Axel Lin @ 2019-02-19 10:00 UTC (permalink / raw)
To: Mark Brown; +Cc: James Ban, Liam Girdwood, linux-kernel, Axel Lin
Fix off-by-one while iterating current_limits array.
The valid index should be 0 ~ n_current_limits -1.
Fixes: c90456e36d9c ("regulator: pv88090: new regulator driver")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/pv88090-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/pv88090-regulator.c b/drivers/regulator/pv88090-regulator.c
index 7a0c15957bd0..2302b0df7630 100644
--- a/drivers/regulator/pv88090-regulator.c
+++ b/drivers/regulator/pv88090-regulator.c
@@ -157,7 +157,7 @@ static int pv88090_set_current_limit(struct regulator_dev *rdev, int min,
int i;
/* search for closest to maximum */
- for (i = info->n_current_limits; i >= 0; i--) {
+ for (i = info->n_current_limits - 1; i >= 0; i--) {
if (min <= info->current_limits[i]
&& max >= info->current_limits[i]) {
return regmap_update_bits(rdev->regmap,
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-19 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-19 10:00 [PATCH 1/3] regulator: pv88060: Fix array out-of-bounds access Axel Lin
2019-02-19 10:00 ` [PATCH 2/3] regulator: pv88080: " Axel Lin
2019-02-19 10:00 ` [PATCH 3/3] regulator: pv88090: " Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®