* [PATCH][next] usb: typec: mux: remove redundant check on variable match
@ 2019-02-19 13:43 Colin King
2019-02-19 14:45 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-02-19 13:43 UTC (permalink / raw)
To: Heikki Krogerus, Greg Kroah-Hartman, linux-usb
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
All the code paths that lead to the return statement are where
match is always true, hence the check to see if it is true is
redundant and can be removed.
Detected by CoverityScan, CID#14769672 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/typec/mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c
index a5947d98824d..b94e2920eb38 100644
--- a/drivers/usb/typec/mux.c
+++ b/drivers/usb/typec/mux.c
@@ -184,7 +184,7 @@ static void *typec_mux_match(struct device_connection *con, int ep, void *data)
if (dev_fwnode(mux->dev) == con->fwnode)
return mux;
- return match ? ERR_PTR(-EPROBE_DEFER) : NULL;
+ return ERR_PTR(-EPROBE_DEFER);
}
/**
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][next] usb: typec: mux: remove redundant check on variable match
2019-02-19 13:43 [PATCH][next] usb: typec: mux: remove redundant check on variable match Colin King
@ 2019-02-19 14:45 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2019-02-19 14:45 UTC (permalink / raw)
To: Colin King; +Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors, linux-kernel
On Tue, Feb 19, 2019 at 01:43:33PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> All the code paths that lead to the return statement are where
> match is always true, hence the check to see if it is true is
> redundant and can be removed.
>
> Detected by CoverityScan, CID#14769672 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/mux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c
> index a5947d98824d..b94e2920eb38 100644
> --- a/drivers/usb/typec/mux.c
> +++ b/drivers/usb/typec/mux.c
> @@ -184,7 +184,7 @@ static void *typec_mux_match(struct device_connection *con, int ep, void *data)
> if (dev_fwnode(mux->dev) == con->fwnode)
> return mux;
>
> - return match ? ERR_PTR(-EPROBE_DEFER) : NULL;
> + return ERR_PTR(-EPROBE_DEFER);
> }
>
> /**
> --
> 2.20.1
thanks,
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-19 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-19 13:43 [PATCH][next] usb: typec: mux: remove redundant check on variable match Colin King
2019-02-19 14:45 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®