* [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs
@ 2019-02-21 14:28 Bo YU
2019-02-21 14:35 ` Gao Xiang
0 siblings, 1 reply; 4+ messages in thread
From: Bo YU @ 2019-02-21 14:28 UTC (permalink / raw)
To: gaoxiang25, yuchao0, gregkh, yuzibode
Cc: Bo Yu, linux-erofs, devel, linux-kernel
From: Bo Yu <tsu.yubo@gmail.com>
Fix sparse warnings:
drivers/staging/erofs/utils.c:134:6: warning: symbol
'erofs_try_to_release_workgroup' was not declared. Should it be static?
Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled")
Cc: Gao Xiang <gaoxiang25@huawei.com>
Cc: Chao Yu <yuchao0@huawei.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Bo Yu <tsu.yubo@gmail.com>
---
drivers/staging/erofs/utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c
index b535898ca753..33cd5ad55cb8 100644
--- a/drivers/staging/erofs/utils.c
+++ b/drivers/staging/erofs/utils.c
@@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)
__erofs_workgroup_free(grp);
}
-bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
+static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
struct erofs_workgroup *grp,
bool cleanup)
{
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs
2019-02-21 14:28 [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs Bo YU
@ 2019-02-21 14:35 ` Gao Xiang
2019-02-22 0:57 ` YU Bo
0 siblings, 1 reply; 4+ messages in thread
From: Gao Xiang @ 2019-02-21 14:35 UTC (permalink / raw)
To: Bo YU
Cc: yuchao0, gregkh, yuzibode, linux-erofs, devel, linux-kernel,
Miao Xie, fangwei (I)
Hi Bo,
On 2019/2/21 22:28, Bo YU wrote:
> From: Bo Yu <tsu.yubo@gmail.com>
>
> Fix sparse warnings:
>
> drivers/staging/erofs/utils.c:134:6: warning: symbol
> 'erofs_try_to_release_workgroup' was not declared. Should it be static?
>
> Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled")
> Cc: Gao Xiang <gaoxiang25@huawei.com>
> Cc: Chao Yu <yuchao0@huawei.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Bo Yu <tsu.yubo@gmail.com>
> ---
> drivers/staging/erofs/utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c
> index b535898ca753..33cd5ad55cb8 100644
> --- a/drivers/staging/erofs/utils.c
> +++ b/drivers/staging/erofs/utils.c
> @@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)
> __erofs_workgroup_free(grp);
> }
>
> -bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
> +static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
> struct erofs_workgroup *grp,
> bool cleanup)
> {
>
Have you looked the latest kernel code?
It seems erofs_try_to_release_workgroup is already be claimed as static...
See:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/erofs/utils.c?h=staging-next#n148
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs
2019-02-21 14:35 ` Gao Xiang
@ 2019-02-22 0:57 ` YU Bo
2019-02-22 1:28 ` Gao Xiang
0 siblings, 1 reply; 4+ messages in thread
From: YU Bo @ 2019-02-22 0:57 UTC (permalink / raw)
To: Gao Xiang
Cc: yuchao0, gregkh, yuzibode, linux-erofs, devel, linux-kernel,
Miao Xie, fangwei (I)
Hi,
On Thu, Feb 21, 2019 at 10:35:01PM +0800, Gao Xiang wrote:
>Hi Bo,
>
>On 2019/2/21 22:28, Bo YU wrote:
>> From: Bo Yu <tsu.yubo@gmail.com>
>>
>> Fix sparse warnings:
>>
>> drivers/staging/erofs/utils.c:134:6: warning: symbol
>> 'erofs_try_to_release_workgroup' was not declared. Should it be static?
>>
>> Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled")
>> Cc: Gao Xiang <gaoxiang25@huawei.com>
>> Cc: Chao Yu <yuchao0@huawei.com>
>> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Signed-off-by: Bo Yu <tsu.yubo@gmail.com>
>> ---
>> drivers/staging/erofs/utils.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c
>> index b535898ca753..33cd5ad55cb8 100644
>> --- a/drivers/staging/erofs/utils.c
>> +++ b/drivers/staging/erofs/utils.c
>> @@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)
>> __erofs_workgroup_free(grp);
>> }
>>
>> -bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>> +static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>> struct erofs_workgroup *grp,
>> bool cleanup)
>> {
>>
>
>Have you looked the latest kernel code?
Emm...yeah.But i pulled linus tree not staging tree :(
Sorry for the noise.
>It seems erofs_try_to_release_workgroup is already be claimed as static...
>
>See:
>https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/erofs/utils.c?h=staging-next#n148
>
>Thanks,
>Gao Xiang
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs
2019-02-22 0:57 ` YU Bo
@ 2019-02-22 1:28 ` Gao Xiang
0 siblings, 0 replies; 4+ messages in thread
From: Gao Xiang @ 2019-02-22 1:28 UTC (permalink / raw)
To: yuzibode
Cc: yuchao0, gregkh, linux-erofs, devel, linux-kernel, Miao Xie, fangwei (I)
On 2019/2/22 8:57, YU Bo wrote:
> Hi,
> On Thu, Feb 21, 2019 at 10:35:01PM +0800, Gao Xiang wrote:
>> Hi Bo,
>>
>> On 2019/2/21 22:28, Bo YU wrote:
>>> From: Bo Yu <tsu.yubo@gmail.com>
>>>
>>> Fix sparse warnings:
>>>
>>> drivers/staging/erofs/utils.c:134:6: warning: symbol
>>> 'erofs_try_to_release_workgroup' was not declared. Should it be static?
>>>
>>> Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled")
>>> Cc: Gao Xiang <gaoxiang25@huawei.com>
>>> Cc: Chao Yu <yuchao0@huawei.com>
>>> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> Signed-off-by: Bo Yu <tsu.yubo@gmail.com>
>>> ---
>>> drivers/staging/erofs/utils.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c
>>> index b535898ca753..33cd5ad55cb8 100644
>>> --- a/drivers/staging/erofs/utils.c
>>> +++ b/drivers/staging/erofs/utils.c
>>> @@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)
>>> __erofs_workgroup_free(grp);
>>> }
>>>
>>> -bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>>> +static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>>> struct erofs_workgroup *grp,
>>> bool cleanup)
>>> {
>>>
>>
>> Have you looked the latest kernel code?
> Emm...yeah.But i pulled linus tree not staging tree :(
> Sorry for the noise.
That is ok. staging tree or linux-next includes the latest source code,
you can check them out :)
Thanks,
Gao Xiang
>
>> It seems erofs_try_to_release_workgroup is already be claimed as static...
>>
>> See:
>> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/erofs/utils.c?h=staging-next#n148
>>
>> Thanks,
>> Gao Xiang
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-22 1:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-21 14:28 [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs Bo YU
2019-02-21 14:35 ` Gao Xiang
2019-02-22 0:57 ` YU Bo
2019-02-22 1:28 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®