* [PATCH] media: imx: vdic: Fix wrong CSI group ID
@ 2019-03-01 23:27 Steve Longerbeam
2019-03-08 15:12 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Steve Longerbeam @ 2019-03-01 23:27 UTC (permalink / raw)
To: linux-media
Cc: Tim Harvey, Steve Longerbeam, Philipp Zabel,
Mauro Carvalho Chehab, Greg Kroah-Hartman,
open list:STAGING SUBSYSTEM, open list
The i.MX7 capture support forgot to change the group ID for the CSI
to the IPU CSI in VDIC sub-device, it was left at the i.MX7 CSI
group ID.
Fixes: 67673ed55084 ("media: staging/imx: rearrange group id to take in account IPU")
Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
---
drivers/staging/media/imx/imx-media-vdic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx-media-vdic.c b/drivers/staging/media/imx/imx-media-vdic.c
index 2808662e2597..d36f6936c365 100644
--- a/drivers/staging/media/imx/imx-media-vdic.c
+++ b/drivers/staging/media/imx/imx-media-vdic.c
@@ -744,7 +744,7 @@ static int vdic_link_setup(struct media_entity *entity,
remote_sd = media_entity_to_v4l2_subdev(remote->entity);
/* direct pad must connect to a CSI */
- if (!(remote_sd->grp_id & IMX_MEDIA_GRP_ID_CSI) ||
+ if (!(remote_sd->grp_id & IMX_MEDIA_GRP_ID_IPU_CSI) ||
remote->index != CSI_SRC_PAD_DIRECT) {
ret = -EINVAL;
goto out;
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] media: imx: vdic: Fix wrong CSI group ID
2019-03-01 23:27 [PATCH] media: imx: vdic: Fix wrong CSI group ID Steve Longerbeam
@ 2019-03-08 15:12 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2019-03-08 15:12 UTC (permalink / raw)
To: Steve Longerbeam, linux-media
Cc: Tim Harvey, Mauro Carvalho Chehab, Greg Kroah-Hartman,
open list:STAGING SUBSYSTEM, open list
On Fri, 2019-03-01 at 15:27 -0800, Steve Longerbeam wrote:
> The i.MX7 capture support forgot to change the group ID for the CSI
> to the IPU CSI in VDIC sub-device, it was left at the i.MX7 CSI
> group ID.
>
> Fixes: 67673ed55084 ("media: staging/imx: rearrange group id to take in account IPU")
>
> Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-08 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-01 23:27 [PATCH] media: imx: vdic: Fix wrong CSI group ID Steve Longerbeam
2019-03-08 15:12 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®