* [PATCH] pinctrl: freescale: fix link errors
@ 2019-03-04 20:26 Arnd Bergmann
2019-03-05 3:00 ` Aisheng Dong
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2019-03-04 20:26 UTC (permalink / raw)
To: Dong Aisheng, Fabio Estevam, Shawn Guo, Stefan Agner, Linus Walleij
Cc: Arnd Bergmann, Pengutronix Kernel Team, Bai Ping,
Guido Günther, Abel Vesa, Lucas Stach, linux-gpio,
linux-kernel
Submitted by Anders Roxell already
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/freescale/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
index e6dff3167a67..e447b996e79f 100644
--- a/drivers/pinctrl/freescale/Kconfig
+++ b/drivers/pinctrl/freescale/Kconfig
@@ -138,14 +138,14 @@ config PINCTRL_IMX8MQ
config PINCTRL_IMX8QM
bool "IMX8QM pinctrl driver"
- depends on ARCH_MXC && ARM64
+ depends on ARCH_MXC && ARM64 && IMX_SCU
select PINCTRL_IMX_SCU
help
Say Y here to enable the imx8qm pinctrl driver
config PINCTRL_IMX8QXP
bool "IMX8QXP pinctrl driver"
- depends on ARCH_MXC && ARM64
+ depends on ARCH_MXC && ARM64 && IMX_SCU
select PINCTRL_IMX_SCU
help
Say Y here to enable the imx8qxp pinctrl driver
--
2.20.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] pinctrl: freescale: fix link errors
2019-03-04 20:26 [PATCH] pinctrl: freescale: fix link errors Arnd Bergmann
@ 2019-03-05 3:00 ` Aisheng Dong
2019-03-05 8:29 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Aisheng Dong @ 2019-03-05 3:00 UTC (permalink / raw)
To: Arnd Bergmann, Fabio Estevam, Shawn Guo, Stefan Agner, Linus Walleij
Cc: Pengutronix Kernel Team, Jacky Bai, Guido Günther,
Abel Vesa, Lucas Stach, linux-gpio, linux-kernel
Hi Arnd,
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Tuesday, March 5, 2019 4:26 AM
>
> Submitted by Anders Roxell already
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
How would suggest to handle this patch?
I've already given an Ack to Andres' v3 patch with a few additional comments,
but seems did not see any follow ups.
https://lore.kernel.org/patchwork/patch/1034330/
Regards
Dong Aisheng
> ---
> drivers/pinctrl/freescale/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> index e6dff3167a67..e447b996e79f 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -138,14 +138,14 @@ config PINCTRL_IMX8MQ
>
> config PINCTRL_IMX8QM
> bool "IMX8QM pinctrl driver"
> - depends on ARCH_MXC && ARM64
> + depends on ARCH_MXC && ARM64 && IMX_SCU
> select PINCTRL_IMX_SCU
> help
> Say Y here to enable the imx8qm pinctrl driver
>
> config PINCTRL_IMX8QXP
> bool "IMX8QXP pinctrl driver"
> - depends on ARCH_MXC && ARM64
> + depends on ARCH_MXC && ARM64 && IMX_SCU
> select PINCTRL_IMX_SCU
> help
> Say Y here to enable the imx8qxp pinctrl driver
> --
> 2.20.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: freescale: fix link errors
2019-03-05 3:00 ` Aisheng Dong
@ 2019-03-05 8:29 ` Arnd Bergmann
2019-03-05 8:36 ` Aisheng Dong
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2019-03-05 8:29 UTC (permalink / raw)
To: Aisheng Dong
Cc: Fabio Estevam, Shawn Guo, Stefan Agner, Linus Walleij,
Pengutronix Kernel Team, Jacky Bai, Guido Günther,
Abel Vesa, Lucas Stach, linux-gpio, linux-kernel
On Tue, Mar 5, 2019 at 4:00 AM Aisheng Dong <aisheng.dong@nxp.com> wrote:
>
> Hi Arnd,
>
> > From: Arnd Bergmann [mailto:arnd@arndb.de]
> > Sent: Tuesday, March 5, 2019 4:26 AM
> >
> > Submitted by Anders Roxell already
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> How would suggest to handle this patch?
>
> I've already given an Ack to Andres' v3 patch with a few additional comments,
> but seems did not see any follow ups.
>
> https://lore.kernel.org/patchwork/patch/1034330/
Sorry about that, I sent this out as part of a long set of bugfixes, and the
comment in my patch was supposed to tell me not to send it. Please just
ignore my submission, and let's go on with his version.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] pinctrl: freescale: fix link errors
2019-03-05 8:29 ` Arnd Bergmann
@ 2019-03-05 8:36 ` Aisheng Dong
0 siblings, 0 replies; 4+ messages in thread
From: Aisheng Dong @ 2019-03-05 8:36 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Fabio Estevam, Shawn Guo, Stefan Agner, Linus Walleij,
Pengutronix Kernel Team, Jacky Bai, Guido Günther,
Abel Vesa, Lucas Stach, linux-gpio, linux-kernel
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Tuesday, March 5, 2019 4:30 PM
> On Tue, Mar 5, 2019 at 4:00 AM Aisheng Dong <aisheng.dong@nxp.com>
> wrote:
> >
> > Hi Arnd,
> >
> > > From: Arnd Bergmann [mailto:arnd@arndb.de]
> > > Sent: Tuesday, March 5, 2019 4:26 AM
> > >
> > > Submitted by Anders Roxell already
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > How would suggest to handle this patch?
> >
> > I've already given an Ack to Andres' v3 patch with a few additional
> > comments, but seems did not see any follow ups.
> >
>
> Sorry about that, I sent this out as part of a long set of bugfixes, and the
> comment in my patch was supposed to tell me not to send it. Please just
> ignore my submission, and let's go on with his version.
>
Never mind, it does remind me that missing fixes.
I will send out that patch for Andres.
Regards
Dong Aisheng
> Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-05 8:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 20:26 [PATCH] pinctrl: freescale: fix link errors Arnd Bergmann
2019-03-05 3:00 ` Aisheng Dong
2019-03-05 8:29 ` Arnd Bergmann
2019-03-05 8:36 ` Aisheng Dong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®