From: kbuild test robot <lkp@intel.com>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: kbuild-all@01.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
H Peter Anvin <hpa@zytor.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Dave Hansen <dave.hansen@intel.com>,
Ashok Raj <ashok.raj@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ravi V Shankar <ravi.v.shankar@intel.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>,
kvm@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH v4 11/17] x86/clearcpuid: Clear CPUID bit in CPUID faulting
Date: Tue, 5 Mar 2019 15:27:18 +0800 [thread overview]
Message-ID: <201903051538.MPXVkHLt%fengguang.wu@intel.com> (raw)
In-Reply-To: <1551494711-213533-12-git-send-email-fenghua.yu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 12533 bytes --]
Hi Peter,
I love your patch! Perhaps something to improve:
[auto build test WARNING on kvm/linux-next]
[also build test WARNING on v5.0 next-20190304]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Fenghua-Yu/x86-split_lock-Enable-AC-exception-for-split-locked-accesses/20190305-044643
base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: i386-randconfig-a1-201909 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
In file included from arch/x86/kernel/cpu/intel.c:22:0:
>> arch/x86/include/asm/insn-eval.h:18:58: warning: 'struct insn' declared inside parameter list
void __user *insn_get_addr_ref(struct insn *insn, struct pt_regs *regs);
^
>> arch/x86/include/asm/insn-eval.h:18:58: warning: its scope is only this definition or declaration, which is probably not what you want
arch/x86/include/asm/insn-eval.h:19:53: warning: 'struct insn' declared inside parameter list
int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs);
^
Cyclomatic Complexity 5 include/linux/compiler.h:__read_once_size
Cyclomatic Complexity 1 include/linux/kasan-checks.h:kasan_check_read
Cyclomatic Complexity 2 arch/x86/include/asm/bitops.h:set_bit
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:constant_test_bit
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:variable_test_bit
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:fls
Cyclomatic Complexity 2 include/linux/bitops.h:get_count_order
Cyclomatic Complexity 1 include/linux/string.h:strnlen
Cyclomatic Complexity 4 include/linux/string.h:strlen
Cyclomatic Complexity 4 include/linux/string.h:memcpy
Cyclomatic Complexity 2 include/linux/string.h:strcpy
Cyclomatic Complexity 1 arch/x86/include/asm/atomic.h:arch_atomic_read
Cyclomatic Complexity 1 include/asm-generic/atomic-instrumented.h:atomic_read
Cyclomatic Complexity 1 arch/x86/include/asm/current.h:get_current
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:native_save_fl
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:native_restore_fl
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:native_irq_disable
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:arch_local_save_flags
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:arch_local_irq_restore
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:arch_local_irq_disable
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:arch_local_irq_save
Cyclomatic Complexity 1 include/linux/jump_label.h:static_key_count
Cyclomatic Complexity 2 include/linux/jump_label.h:static_key_false
Cyclomatic Complexity 1 arch/x86/include/asm/ptrace.h:user_64bit_mode
Cyclomatic Complexity 1 arch/x86/include/asm/msr.h:__rdmsr
Cyclomatic Complexity 1 arch/x86/include/asm/msr.h:__wrmsr
Cyclomatic Complexity 2 arch/x86/include/asm/msr.h:native_read_msr
Cyclomatic Complexity 2 arch/x86/include/asm/msr.h:native_read_msr_safe
Cyclomatic Complexity 2 arch/x86/include/asm/msr.h:native_write_msr
Cyclomatic Complexity 1 arch/x86/include/asm/msr.h:wrmsrl
Cyclomatic Complexity 1 arch/x86/include/asm/msr.h:rdmsrl_safe
Cyclomatic Complexity 1 arch/x86/include/asm/processor.h:native_cpuid
Cyclomatic Complexity 1 arch/x86/include/asm/processor.h:native_cpuid_eax
Cyclomatic Complexity 1 arch/x86/include/asm/processor.h:cpuid
Cyclomatic Complexity 1 arch/x86/include/asm/processor.h:cpuid_count
Cyclomatic Complexity 1 arch/x86/include/asm/processor.h:cpuid_eax
Cyclomatic Complexity 2 include/linux/thread_info.h:test_ti_thread_flag
Cyclomatic Complexity 2 include/linux/thread_info.h:check_object_size
Cyclomatic Complexity 2 include/linux/thread_info.h:copy_overflow
Cyclomatic Complexity 4 include/linux/thread_info.h:check_copy_size
Cyclomatic Complexity 2 include/linux/uaccess.h:copy_from_user
Cyclomatic Complexity 1 arch/x86/include/asm/microcode_intel.h:intel_get_microcode_revision
Cyclomatic Complexity 1 arch/x86/kernel/cpu/intel.c:forcempx_setup
Cyclomatic Complexity 1 arch/x86/kernel/cpu/intel.c:ring3mwait_disable
Cyclomatic Complexity 5 arch/x86/kernel/cpu/intel.c:probe_xeon_phi_r3mwait
Cyclomatic Complexity 6 arch/x86/kernel/cpu/intel.c:bad_spectre_microcode
Cyclomatic Complexity 1 arch/x86/kernel/cpu/intel.c:forcepae_setup
Cyclomatic Complexity 1 arch/x86/kernel/cpu/intel.c:srat_detect_node
Cyclomatic Complexity 4 arch/x86/kernel/cpu/intel.c:init_cpuid_fault
Cyclomatic Complexity 2 arch/x86/kernel/cpu/intel.c:init_intel_misc_features
Cyclomatic Complexity 4 arch/x86/kernel/cpu/intel.c:intel_size_cache
Cyclomatic Complexity 38 arch/x86/kernel/cpu/intel.c:intel_tlb_lookup
Cyclomatic Complexity 6 arch/x86/kernel/cpu/intel.c:intel_detect_tlb
Cyclomatic Complexity 5 arch/x86/kernel/cpu/intel.c:init_intel_energy_perf
Cyclomatic Complexity 1 arch/x86/kernel/cpu/intel.c:intel_bsp_resume
Cyclomatic Complexity 16 arch/x86/kernel/cpu/intel.c:detect_tme
Cyclomatic Complexity 9 arch/x86/kernel/cpu/intel.c:intel_smp_check
Cyclomatic Complexity 9 arch/x86/kernel/cpu/intel.c:detect_vmx_virtcap
Cyclomatic Complexity 13 arch/x86/kernel/cpu/intel.c:intel_workarounds
Cyclomatic Complexity 1 arch/x86/include/asm/microcode.h:exit_amd_microcode
Cyclomatic Complexity 4 arch/x86/kernel/cpu/intel.c:check_mpx_erratum
Cyclomatic Complexity 37 arch/x86/kernel/cpu/intel.c:early_init_intel
Cyclomatic Complexity 30 arch/x86/kernel/cpu/intel.c:init_intel
Cyclomatic Complexity 3 arch/x86/kernel/cpu/intel.c:ppro_with_ram_bug
Cyclomatic Complexity 8 arch/x86/kernel/cpu/intel.c:fixup_cpuid_exception
Cyclomatic Complexity 4 arch/x86/kernel/cpu/intel.c:init_core_capability
--
In file included from arch/x86//kernel/cpu/intel.c:22:0:
>> arch/x86/include/asm/insn-eval.h:18:58: warning: 'struct insn' declared inside parameter list
void __user *insn_get_addr_ref(struct insn *insn, struct pt_regs *regs);
^
>> arch/x86/include/asm/insn-eval.h:18:58: warning: its scope is only this definition or declaration, which is probably not what you want
arch/x86/include/asm/insn-eval.h:19:53: warning: 'struct insn' declared inside parameter list
int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs);
^
Cyclomatic Complexity 5 include/linux/compiler.h:__read_once_size
Cyclomatic Complexity 1 include/linux/kasan-checks.h:kasan_check_read
Cyclomatic Complexity 2 arch/x86/include/asm/bitops.h:set_bit
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:constant_test_bit
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:variable_test_bit
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:fls
Cyclomatic Complexity 2 include/linux/bitops.h:get_count_order
Cyclomatic Complexity 1 include/linux/string.h:strnlen
Cyclomatic Complexity 4 include/linux/string.h:strlen
Cyclomatic Complexity 4 include/linux/string.h:memcpy
Cyclomatic Complexity 2 include/linux/string.h:strcpy
Cyclomatic Complexity 1 arch/x86/include/asm/atomic.h:arch_atomic_read
Cyclomatic Complexity 1 include/asm-generic/atomic-instrumented.h:atomic_read
Cyclomatic Complexity 1 arch/x86/include/asm/current.h:get_current
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:native_save_fl
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:native_restore_fl
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:native_irq_disable
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:arch_local_save_flags
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:arch_local_irq_restore
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:arch_local_irq_disable
Cyclomatic Complexity 1 arch/x86/include/asm/irqflags.h:arch_local_irq_save
Cyclomatic Complexity 1 include/linux/jump_label.h:static_key_count
Cyclomatic Complexity 2 include/linux/jump_label.h:static_key_false
Cyclomatic Complexity 1 arch/x86/include/asm/ptrace.h:user_64bit_mode
Cyclomatic Complexity 1 arch/x86/include/asm/msr.h:__rdmsr
Cyclomatic Complexity 1 arch/x86/include/asm/msr.h:__wrmsr
Cyclomatic Complexity 2 arch/x86/include/asm/msr.h:native_read_msr
Cyclomatic Complexity 2 arch/x86/include/asm/msr.h:native_read_msr_safe
Cyclomatic Complexity 2 arch/x86/include/asm/msr.h:native_write_msr
Cyclomatic Complexity 1 arch/x86/include/asm/msr.h:wrmsrl
Cyclomatic Complexity 1 arch/x86/include/asm/msr.h:rdmsrl_safe
Cyclomatic Complexity 1 arch/x86/include/asm/processor.h:native_cpuid
Cyclomatic Complexity 1 arch/x86/include/asm/processor.h:native_cpuid_eax
Cyclomatic Complexity 1 arch/x86/include/asm/processor.h:cpuid
Cyclomatic Complexity 1 arch/x86/include/asm/processor.h:cpuid_count
Cyclomatic Complexity 1 arch/x86/include/asm/processor.h:cpuid_eax
Cyclomatic Complexity 2 include/linux/thread_info.h:test_ti_thread_flag
Cyclomatic Complexity 2 include/linux/thread_info.h:check_object_size
Cyclomatic Complexity 2 include/linux/thread_info.h:copy_overflow
Cyclomatic Complexity 4 include/linux/thread_info.h:check_copy_size
Cyclomatic Complexity 2 include/linux/uaccess.h:copy_from_user
Cyclomatic Complexity 1 arch/x86/include/asm/microcode_intel.h:intel_get_microcode_revision
Cyclomatic Complexity 1 arch/x86//kernel/cpu/intel.c:forcempx_setup
Cyclomatic Complexity 1 arch/x86//kernel/cpu/intel.c:ring3mwait_disable
Cyclomatic Complexity 5 arch/x86//kernel/cpu/intel.c:probe_xeon_phi_r3mwait
Cyclomatic Complexity 6 arch/x86//kernel/cpu/intel.c:bad_spectre_microcode
Cyclomatic Complexity 1 arch/x86//kernel/cpu/intel.c:forcepae_setup
Cyclomatic Complexity 1 arch/x86//kernel/cpu/intel.c:srat_detect_node
Cyclomatic Complexity 4 arch/x86//kernel/cpu/intel.c:init_cpuid_fault
Cyclomatic Complexity 2 arch/x86//kernel/cpu/intel.c:init_intel_misc_features
Cyclomatic Complexity 4 arch/x86//kernel/cpu/intel.c:intel_size_cache
Cyclomatic Complexity 38 arch/x86//kernel/cpu/intel.c:intel_tlb_lookup
Cyclomatic Complexity 6 arch/x86//kernel/cpu/intel.c:intel_detect_tlb
Cyclomatic Complexity 5 arch/x86//kernel/cpu/intel.c:init_intel_energy_perf
Cyclomatic Complexity 1 arch/x86//kernel/cpu/intel.c:intel_bsp_resume
Cyclomatic Complexity 16 arch/x86//kernel/cpu/intel.c:detect_tme
Cyclomatic Complexity 9 arch/x86//kernel/cpu/intel.c:intel_smp_check
Cyclomatic Complexity 9 arch/x86//kernel/cpu/intel.c:detect_vmx_virtcap
Cyclomatic Complexity 13 arch/x86//kernel/cpu/intel.c:intel_workarounds
Cyclomatic Complexity 1 arch/x86/include/asm/microcode.h:exit_amd_microcode
Cyclomatic Complexity 4 arch/x86//kernel/cpu/intel.c:check_mpx_erratum
Cyclomatic Complexity 37 arch/x86//kernel/cpu/intel.c:early_init_intel
Cyclomatic Complexity 30 arch/x86//kernel/cpu/intel.c:init_intel
Cyclomatic Complexity 3 arch/x86//kernel/cpu/intel.c:ppro_with_ram_bug
Cyclomatic Complexity 8 arch/x86//kernel/cpu/intel.c:fixup_cpuid_exception
Cyclomatic Complexity 4 arch/x86//kernel/cpu/intel.c:init_core_capability
vim +18 arch/x86/include/asm/insn-eval.h
4efea85f Ricardo Neri 2017-10-27 17
32542ee2 Ricardo Neri 2017-10-27 @18 void __user *insn_get_addr_ref(struct insn *insn, struct pt_regs *regs);
e5e45f11 Ricardo Neri 2017-10-27 19 int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs);
bd5a410a Ricardo Neri 2017-10-27 20 unsigned long insn_get_seg_base(struct pt_regs *regs, int seg_reg_idx);
e2a5dca7 Borislav Petkov 2017-11-23 21 int insn_get_code_seg_params(struct pt_regs *regs);
32542ee2 Ricardo Neri 2017-10-27 22
:::::: The code at line 18 was first introduced by commit
:::::: 32542ee295bec38e5e1608f8c9d6d28e5a7e6112 x86/mpx, x86/insn: Relocate insn util functions to a new insn-eval file
:::::: TO: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
:::::: CC: Thomas Gleixner <tglx@linutronix.de>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36754 bytes --]
next prev parent reply other threads:[~2019-03-05 7:43 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 2:44 [PATCH v4 00/17] x86/split_lock: Enable #AC exception for split locked accesses Fenghua Yu
2019-03-02 2:44 ` [PATCH v4 01/17] x86/common: Align cpu_caps_cleared and cpu_caps_set to unsigned long Fenghua Yu
2019-03-04 8:33 ` Paolo Bonzini
2019-03-04 10:17 ` Peter Zijlstra
2019-03-04 10:48 ` Paolo Bonzini
2019-03-04 12:44 ` Peter Zijlstra
2019-03-04 13:13 ` Paolo Bonzini
2019-03-02 2:44 ` [PATCH v4 02/17] drivers/net/b44: Align pwol_mask to unsigned long for better performance Fenghua Yu
2019-03-04 10:00 ` Peter Zijlstra
2019-03-04 14:45 ` Fenghua Yu
2019-03-04 15:27 ` Peter Zijlstra
2019-03-02 2:44 ` [PATCH v4 03/17] wlcore: Align reg_ch_conf_pending and tmp_ch_bitmap " Fenghua Yu
2019-03-04 10:11 ` Peter Zijlstra
2019-03-04 10:46 ` Paolo Bonzini
2019-03-04 12:41 ` Peter Zijlstra
2019-03-04 13:09 ` Paolo Bonzini
2019-03-04 13:30 ` Peter Zijlstra
2019-03-04 14:40 ` Fenghua Yu
2019-03-04 15:54 ` Paolo Bonzini
2019-03-02 2:44 ` [PATCH v4 04/17] x86/split_lock: Align x86_capability to unsigned long to avoid split locked access Fenghua Yu
2019-03-04 18:52 ` Dave Hansen
2019-03-04 19:15 ` Fenghua Yu
2019-03-04 19:29 ` Dave Hansen
2019-03-04 20:08 ` Peter Zijlstra
2019-03-04 20:12 ` Peter Zijlstra
2019-03-02 2:44 ` [PATCH v4 05/17] x86/cpufeatures: Enumerate IA32_CORE_CAPABILITIES MSR Fenghua Yu
2019-03-04 18:53 ` Dave Hansen
2019-03-04 18:55 ` Yu, Fenghua
2019-03-04 19:01 ` Dave Hansen
2019-03-02 2:45 ` [PATCH v4 06/17] x86/msr-index: Define IA32_CORE_CAPABILITY MSR and #AC exception for split lock bit Fenghua Yu
2019-03-02 2:45 ` [PATCH v4 07/17] x86/split_lock: Enumerate #AC for split lock by MSR IA32_CORE_CAPABILITY Fenghua Yu
2019-03-04 18:58 ` Dave Hansen
2019-03-04 18:59 ` Fenghua Yu
2019-03-04 19:19 ` Dave Hansen
2019-03-02 2:45 ` [PATCH v4 08/17] x86/clearcpuid: Support multiple clearcpuid options Fenghua Yu
2019-03-02 2:45 ` [PATCH v4 09/17] x86/clearcpuid: Support feature flag string in kernel option clearcpuid Fenghua Yu
2019-03-02 2:45 ` [PATCH v4 10/17] x86/clearcpuid: Apply cleared feature bits that are forced set before Fenghua Yu
2019-03-02 2:45 ` [PATCH v4 11/17] x86/clearcpuid: Clear CPUID bit in CPUID faulting Fenghua Yu
2019-03-04 22:04 ` kbuild test robot
2019-03-05 7:27 ` kbuild test robot [this message]
2019-03-02 2:45 ` [PATCH v4 12/17] Change document for kernel option clearcpuid Fenghua Yu
2019-03-02 2:45 ` [PATCH v4 13/17] x86/split_lock: Handle #AC exception for split lock Fenghua Yu
2019-03-02 2:45 ` [PATCH v4 14/17] x86/split_lock: Add a sysfs interface to allow user to enable or disable split lock detection on all CPUs during run time Fenghua Yu
2019-03-02 2:45 ` [PATCH v4 15/17] kvm: x86: Report CORE_CAPABILITY on GET_SUPPORTED_CPUID Fenghua Yu
2019-03-04 8:38 ` Paolo Bonzini
2019-03-04 10:47 ` Xiaoyao Li
2019-03-04 10:49 ` Paolo Bonzini
2019-03-04 11:10 ` Xiaoyao Li
2019-03-04 11:14 ` Paolo Bonzini
2019-03-04 11:21 ` Xiaoyao Li
2019-03-05 7:03 ` Xiaoyao Li
2019-03-02 2:45 ` [PATCH v4 16/17] kvm: x86: Add support IA32_CORE_CAPABILITY MSR Fenghua Yu
2019-03-04 8:42 ` Paolo Bonzini
2019-03-04 12:32 ` Xiaoyao Li
2019-03-08 6:10 ` Xiaoyao Li
2019-03-08 7:54 ` Paolo Bonzini
2019-03-08 8:03 ` Xiaoyao Li
2019-03-02 2:45 ` [PATCH v4 17/17] kvm: vmx: Emulate TEST_CTL MSR Fenghua Yu
2019-03-09 2:31 ` Xiaoyao Li
2019-03-11 13:31 ` Paolo Bonzini
2019-03-11 15:10 ` Xiaoyao Li
2019-03-11 15:21 ` Paolo Bonzini
2019-03-11 16:58 ` Xiaoyao Li
2019-03-04 21:55 ` [PATCH v4 00/17] x86/split_lock: Enable #AC exception for split locked accesses Konrad Rzeszutek Wilk
2019-03-05 0:06 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201903051538.MPXVkHLt%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=kbuild-all@01.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®