* [PATCH] extcon-ptn5150: fix COMPILE_TEST dependencies
@ 2019-03-06 11:08 ` Arnd Bergmann
2019-03-06 15:49 ` Randy Dunlap
2019-03-07 0:58 ` Chanwoo Choi
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2019-03-06 11:08 UTC (permalink / raw)
To: MyungJoo Ham, Chanwoo Choi; +Cc: Arnd Bergmann, Vijai Kumar K, linux-kernel
The PTN5150 dependencies look like they were meant to do the
right thing, but they actually should not allow building without
I2C for compile testing, as that results in a Kconfig warning
and subsequent build failure:
WARNING: unmet direct dependencies detected for REGMAP_I2C
Depends on [m]: I2C [=m]
Selected by [y]:
- EXTCON_PTN5150 [=y] && EXTCON [=y] && (I2C [=m] && GPIOLIB [=y] || COMPILE_TEST [=y])
Selected by [m]:
- EEPROM_AT24 [=m] && I2C [=m] && SYSFS [=y]
- KEYBOARD_CAP11XX [=m] && !UML && INPUT [=y] && INPUT_KEYBOARD [=y] && OF [=y] && I2C [=m]
- INPUT_DRV260X_HAPTICS [=m] && !UML && INPUT_MISC [=y] && INPUT [=y] && I2C [=m] && (GPIOLIB [=y] || COMPILE_TEST [=y])
- ... [many others]
Add parentheses around the expression so we can compile-test
without GPIOLIB but not without I2C.
Fixes: 4ed754de2d66 ("extcon: Add support for ptn5150 extcon driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/extcon/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index 8e17149655f0..540e8cd16ee6 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -116,7 +116,7 @@ config EXTCON_PALMAS
config EXTCON_PTN5150
tristate "NXP PTN5150 CC LOGIC USB EXTCON support"
- depends on I2C && GPIOLIB || COMPILE_TEST
+ depends on I2C && (GPIOLIB || COMPILE_TEST)
select REGMAP_I2C
help
Say Y here to enable support for USB peripheral and USB host
--
2.20.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] extcon-ptn5150: fix COMPILE_TEST dependencies
2019-03-06 11:08 ` [PATCH] extcon-ptn5150: fix COMPILE_TEST dependencies Arnd Bergmann
@ 2019-03-06 15:49 ` Randy Dunlap
2019-03-07 0:58 ` Chanwoo Choi
2019-03-07 0:58 ` Chanwoo Choi
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2019-03-06 15:49 UTC (permalink / raw)
To: Arnd Bergmann, MyungJoo Ham, Chanwoo Choi; +Cc: Vijai Kumar K, linux-kernel
On 3/6/19 3:08 AM, Arnd Bergmann wrote:
> The PTN5150 dependencies look like they were meant to do the
> right thing, but they actually should not allow building without
> I2C for compile testing, as that results in a Kconfig warning
> and subsequent build failure:
>
> WARNING: unmet direct dependencies detected for REGMAP_I2C
> Depends on [m]: I2C [=m]
> Selected by [y]:
> - EXTCON_PTN5150 [=y] && EXTCON [=y] && (I2C [=m] && GPIOLIB [=y] || COMPILE_TEST [=y])
> Selected by [m]:
> - EEPROM_AT24 [=m] && I2C [=m] && SYSFS [=y]
> - KEYBOARD_CAP11XX [=m] && !UML && INPUT [=y] && INPUT_KEYBOARD [=y] && OF [=y] && I2C [=m]
> - INPUT_DRV260X_HAPTICS [=m] && !UML && INPUT_MISC [=y] && INPUT [=y] && I2C [=m] && (GPIOLIB [=y] || COMPILE_TEST [=y])
> - ... [many others]
>
> Add parentheses around the expression so we can compile-test
> without GPIOLIB but not without I2C.
>
> Fixes: 4ed754de2d66 ("extcon: Add support for ptn5150 extcon driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Chanwoo,
You might want to drop my patch and use this one from Arnd instead...
> ---
> drivers/extcon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 8e17149655f0..540e8cd16ee6 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -116,7 +116,7 @@ config EXTCON_PALMAS
>
> config EXTCON_PTN5150
> tristate "NXP PTN5150 CC LOGIC USB EXTCON support"
> - depends on I2C && GPIOLIB || COMPILE_TEST
> + depends on I2C && (GPIOLIB || COMPILE_TEST)
> select REGMAP_I2C
> help
> Say Y here to enable support for USB peripheral and USB host
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] extcon-ptn5150: fix COMPILE_TEST dependencies
2019-03-06 15:49 ` Randy Dunlap
@ 2019-03-07 0:58 ` Chanwoo Choi
0 siblings, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2019-03-07 0:58 UTC (permalink / raw)
To: Randy Dunlap, Arnd Bergmann, MyungJoo Ham; +Cc: Vijai Kumar K, linux-kernel
Hi Randy,
On 19. 3. 7. 오전 12:49, Randy Dunlap wrote:
> On 3/6/19 3:08 AM, Arnd Bergmann wrote:
>> The PTN5150 dependencies look like they were meant to do the
>> right thing, but they actually should not allow building without
>> I2C for compile testing, as that results in a Kconfig warning
>> and subsequent build failure:
>>
>> WARNING: unmet direct dependencies detected for REGMAP_I2C
>> Depends on [m]: I2C [=m]
>> Selected by [y]:
>> - EXTCON_PTN5150 [=y] && EXTCON [=y] && (I2C [=m] && GPIOLIB [=y] || COMPILE_TEST [=y])
>> Selected by [m]:
>> - EEPROM_AT24 [=m] && I2C [=m] && SYSFS [=y]
>> - KEYBOARD_CAP11XX [=m] && !UML && INPUT [=y] && INPUT_KEYBOARD [=y] && OF [=y] && I2C [=m]
>> - INPUT_DRV260X_HAPTICS [=m] && !UML && INPUT_MISC [=y] && INPUT [=y] && I2C [=m] && (GPIOLIB [=y] || COMPILE_TEST [=y])
>> - ... [many others]
>>
>> Add parentheses around the expression so we can compile-test
>> without GPIOLIB but not without I2C.
>>
>> Fixes: 4ed754de2d66 ("extcon: Add support for ptn5150 extcon driver")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Hi Chanwoo,
>
> You might want to drop my patch and use this one from Arnd instead...
Thanks for your comment. I'll do that.
>
>
>> ---
>> drivers/extcon/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
>> index 8e17149655f0..540e8cd16ee6 100644
>> --- a/drivers/extcon/Kconfig
>> +++ b/drivers/extcon/Kconfig
>> @@ -116,7 +116,7 @@ config EXTCON_PALMAS
>>
>> config EXTCON_PTN5150
>> tristate "NXP PTN5150 CC LOGIC USB EXTCON support"
>> - depends on I2C && GPIOLIB || COMPILE_TEST
>> + depends on I2C && (GPIOLIB || COMPILE_TEST)
>> select REGMAP_I2C
>> help
>> Say Y here to enable support for USB peripheral and USB host
>>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] extcon-ptn5150: fix COMPILE_TEST dependencies
2019-03-06 11:08 ` [PATCH] extcon-ptn5150: fix COMPILE_TEST dependencies Arnd Bergmann
2019-03-06 15:49 ` Randy Dunlap
@ 2019-03-07 0:58 ` Chanwoo Choi
1 sibling, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2019-03-07 0:58 UTC (permalink / raw)
To: Arnd Bergmann, MyungJoo Ham; +Cc: Vijai Kumar K, linux-kernel
Hi,
On 19. 3. 6. 오후 8:08, Arnd Bergmann wrote:
> The PTN5150 dependencies look like they were meant to do the
> right thing, but they actually should not allow building without
> I2C for compile testing, as that results in a Kconfig warning
> and subsequent build failure:
>
> WARNING: unmet direct dependencies detected for REGMAP_I2C
> Depends on [m]: I2C [=m]
> Selected by [y]:
> - EXTCON_PTN5150 [=y] && EXTCON [=y] && (I2C [=m] && GPIOLIB [=y] || COMPILE_TEST [=y])
> Selected by [m]:
> - EEPROM_AT24 [=m] && I2C [=m] && SYSFS [=y]
> - KEYBOARD_CAP11XX [=m] && !UML && INPUT [=y] && INPUT_KEYBOARD [=y] && OF [=y] && I2C [=m]
> - INPUT_DRV260X_HAPTICS [=m] && !UML && INPUT_MISC [=y] && INPUT [=y] && I2C [=m] && (GPIOLIB [=y] || COMPILE_TEST [=y])
> - ... [many others]
>
> Add parentheses around the expression so we can compile-test
> without GPIOLIB but not without I2C.
>
> Fixes: 4ed754de2d66 ("extcon: Add support for ptn5150 extcon driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/extcon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 8e17149655f0..540e8cd16ee6 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -116,7 +116,7 @@ config EXTCON_PALMAS
>
> config EXTCON_PTN5150
> tristate "NXP PTN5150 CC LOGIC USB EXTCON support"
> - depends on I2C && GPIOLIB || COMPILE_TEST
> + depends on I2C && (GPIOLIB || COMPILE_TEST)
> select REGMAP_I2C
> help
> Say Y here to enable support for USB peripheral and USB host
>
Applied it to extcon-fixes branch for v5.0-rc2.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-07 0:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190306110913epcas4p1a346e77b3523020d04ee385b5eac80e9@epcas4p1.samsung.com>
2019-03-06 11:08 ` [PATCH] extcon-ptn5150: fix COMPILE_TEST dependencies Arnd Bergmann
2019-03-06 15:49 ` Randy Dunlap
2019-03-07 0:58 ` Chanwoo Choi
2019-03-07 0:58 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®