From: Steffen Klassert <steffen.klassert@secunet.com>
To: Su Yanjun <suyj.fnst@cn.fujitsu.com>
Cc: <davem@davemloft.net>, <fw@strlen.de>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm
Date: Wed, 6 Mar 2019 12:33:53 +0100 [thread overview]
Message-ID: <20190306113353.GC3758@gauss3.secunet.de> (raw)
In-Reply-To: <1551748754-16895-1-git-send-email-suyj.fnst@cn.fujitsu.com>
On Mon, Mar 04, 2019 at 08:19:14PM -0500, Su Yanjun wrote:
> For rcu protected pointers, we'd better add '__rcu' for them.
>
> Once added '__rcu' tag for rcu protected pointer, the sparse tool reports
> warnings.
>
> net/xfrm/xfrm_user.c:1198:39: sparse: expected struct sock *sk
> net/xfrm/xfrm_user.c:1198:39: sparse: got struct sock [noderef] <asn:4> *nlsk
> [...]
>
> So introduce a new wrapper function of nlmsg_unicast to handle type
> conversions.
>
> No functional change.
While that was true for v1 of that patch, it is not
true for this version. This fixes a direct access
of a rcu protected socket. So please add a proper
'Fixes' tag.
prev parent reply other threads:[~2019-03-06 11:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 1:19 Su Yanjun
2019-03-06 11:33 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190306113353.GC3758@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=suyj.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®