* [PATCH] mmc_spi: add a status check for spi_sync_locked
@ 2019-03-10 7:53 Kangjie Lu
2019-03-10 12:58 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Kangjie Lu @ 2019-03-10 7:53 UTC (permalink / raw)
To: kjlu
Cc: pakki001, Ulf Hansson, Linus Walleij, Laurent Pinchart,
Jonathan Neuschäfer, linux-mmc, linux-kernel
In case spi_sync_locked fails, the fix reports the error and
returns the error code upstream.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/mmc/host/mmc_spi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
index 1b1498805972..32fea585262b 100644
--- a/drivers/mmc/host/mmc_spi.c
+++ b/drivers/mmc/host/mmc_spi.c
@@ -819,6 +819,10 @@ mmc_spi_readblock(struct mmc_spi_host *host, struct spi_transfer *t,
}
status = spi_sync_locked(spi, &host->m);
+ if (status < 0) {
+ dev_dbg(&spi->dev, "read error %02x (%d)\n", status, status);
+ return status;
+ }
if (host->dma_dev) {
dma_sync_single_for_cpu(host->dma_dev,
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mmc_spi: add a status check for spi_sync_locked
2019-03-10 7:53 [PATCH] mmc_spi: add a status check for spi_sync_locked Kangjie Lu
@ 2019-03-10 12:58 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2019-03-10 12:58 UTC (permalink / raw)
To: Kangjie Lu
Cc: pakki001, Ulf Hansson, Linus Walleij, Laurent Pinchart,
Jonathan Neuschäfer, linux-mmc, linux-kernel
Hi Kangjie,
Thank you for the patch.
On Sun, Mar 10, 2019 at 01:53:05AM -0600, Kangjie Lu wrote:
> In case spi_sync_locked fails, the fix reports the error and
> returns the error code upstream.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/mmc/host/mmc_spi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
> index 1b1498805972..32fea585262b 100644
> --- a/drivers/mmc/host/mmc_spi.c
> +++ b/drivers/mmc/host/mmc_spi.c
> @@ -819,6 +819,10 @@ mmc_spi_readblock(struct mmc_spi_host *host, struct spi_transfer *t,
> }
>
> status = spi_sync_locked(spi, &host->m);
> + if (status < 0) {
> + dev_dbg(&spi->dev, "read error %02x (%d)\n", status, status);
I don't think you need to print the status in both hex and in decimal
forms. %d should be enough, error codes are usually printed in decimal
in the kernel. Apart from that,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + return status;
> + }
>
> if (host->dma_dev) {
> dma_sync_single_for_cpu(host->dma_dev,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-10 12:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-10 7:53 [PATCH] mmc_spi: add a status check for spi_sync_locked Kangjie Lu
2019-03-10 12:58 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®